emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Bastien <bzg@gnu.org>
Cc: "emacs-orgmode list" <emacs-orgmode@gnu.org>,
	"András Simonyi" <andras.simonyi@gmail.com>
Subject: Re: [PATCH] oc-csl: Add support for the text and year citation styles
Date: Tue, 28 Sep 2021 16:58:33 +0200	[thread overview]
Message-ID: <87sfxozqzq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87fstoojam.fsf@gnu.org> (Bastien's message of "Tue, 28 Sep 2021 16:40:17 +0200")

Hello,

Bastien <bzg@gnu.org> writes:

> Dear András,
>
> András Simonyi <andras.simonyi@gmail.com> writes:
>
>> the attached patch adds support for the text (textual) and year
>> (year-only) citation styles in the CSL org-cite processor.
>
> Applied, thank you very much!

The function `org-cite-csl--create-structure-params' probably needs to
be refactored, as the pcase pattern is going to put the byte-compiler to
a knee. See, e.g., a6d93cfb621356893dc69fc779894c0984cedbd1 and related
thread at <http://lists.gnu.org/r/emacs-orgmode/2021-08/msg00100.html>.

Regards,
-- 
Nicolas Goaziou


  reply	other threads:[~2021-09-28 14:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 13:12 [PATCH] oc-csl: Add support for the text and year citation styles András Simonyi
2021-09-28 14:40 ` Bastien
2021-09-28 14:58   ` Nicolas Goaziou [this message]
2021-09-28 15:03   ` Max Nikulin
2021-09-28 15:16     ` András Simonyi
2021-09-28 16:39       ` András Simonyi
2021-09-28 16:54         ` Max Nikulin
2021-09-28 16:56         ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfxozqzq.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=andras.simonyi@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).