From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id NfUSLfIgcmJlCgAAbAwnHQ (envelope-from ) for ; Wed, 04 May 2022 08:45:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oDIBLPIgcmIw9wAA9RJhRA (envelope-from ) for ; Wed, 04 May 2022 08:45:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 359493E9BA for ; Wed, 4 May 2022 08:45:06 +0200 (CEST) Received: from localhost ([::1]:33000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nm8kx-0007G8-T5 for larch@yhetil.org; Wed, 04 May 2022 02:45:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm8dg-0005jE-HD for emacs-orgmode@gnu.org; Wed, 04 May 2022 02:37:33 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:43636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nm8de-0002sF-V6 for emacs-orgmode@gnu.org; Wed, 04 May 2022 02:37:32 -0400 Received: by mail-pj1-x1031.google.com with SMTP id j8-20020a17090a060800b001cd4fb60dccso460291pjj.2 for ; Tue, 03 May 2022 23:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=trIrsujsKDxEjS7bPYd245+3mvgBiNZ6YgSeOZzWCkM=; b=ef7fb0dSlRbO2HwhuI5/3eVuToot1dBmQ6QK7lnVUy3UGgXj065bpZu2qPqeDyjUHc 5QTxrt3UvP0DPWKHC7B/W8l+/BMdk6wD3DufbD6+O5953Lj2y0yVN2an7/7IpTxxwnq6 XAfMjIC9+oTkoOtWP4AtaazRCAKr9OXH/VGubUcWc9DP01SAwZPifrTurXFO6c1NMlhK oCPi0TOF6oopOzzhGAkFYslGUskqvUkGtPDU6QpHnTGeDVBmrMuh+8VnQY0lBQxZV+/V gi2EJunhiutnOML+VL1bvub9/TOqteI3/G0hQkYKMYvGstRop29swMsOUJKzyhjingkZ 9rZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=trIrsujsKDxEjS7bPYd245+3mvgBiNZ6YgSeOZzWCkM=; b=6zWGHBQ7/gy0EHAwmxm46A9QUPuaN4zV5WFNmeBC3SqsEEY4P3IZdtoJCDbpRKST34 oHQ8syaod/2mUjkzXsAT375LQrkCp3FAaJhpEi4LOEzGS1rhaPw2m3GxFMQOylmNJEB0 tlmvXbROHsLrv9XYDfYP43FPPgBhvKmBwVHoH+OnypQ/e4bZMXirTdCvUJ8i4h4l6r6z s6of9QyqhaX57xQ/8w/thg7dRnaEJsaIbBOFhNGs9VqEHw9H0aAIgP6Ii6+vu1Hs3fyr bVHgcUB2z6xfrF0JvlW3v7lOuxrfMKdE26zNeeLANhVjoXNpSCzBlOhdHdQvpVt0VDN6 UWyw== X-Gm-Message-State: AOAM5302uPSzUuGBwLPZ8kF913uU4HG7YOHUsKNGj3k3c623O4pzPPHK b8N0p5kXw5rog1zeX9leaZfk/dFPESZHPDKs X-Google-Smtp-Source: ABdhPJwQuR4kAHrtyogD1IIMfJNy8X/+BRAPg1jQsBrDfQ4Y2422aNOBFoUDhfxtRmMpycB5cVjnqw== X-Received: by 2002:a17:90b:704:b0:1d7:367a:f16b with SMTP id s4-20020a17090b070400b001d7367af16bmr8859542pjz.197.1651646249283; Tue, 03 May 2022 23:37:29 -0700 (PDT) Received: from localhost ([37.120.210.2]) by smtp.gmail.com with ESMTPSA id b4-20020a170902650400b0015e8d4eb1dcsm7494456plk.38.2022.05.03.23.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 23:37:28 -0700 (PDT) From: Ihor Radchenko To: Tom Gillespie Cc: emacs-orgmode Subject: Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding In-Reply-To: References: <87y2cvloay.fsf@gnu.org> <149145640c25d2ae191ab87c7056e372f9904370.1643454546.git.yantar92@gmail.com> Date: Wed, 04 May 2022 14:38:15 +0800 Message-ID: <87sfpphkfc.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651646706; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=trIrsujsKDxEjS7bPYd245+3mvgBiNZ6YgSeOZzWCkM=; b=XVpEV714ZV7s8Nhgzj/4H2PSRdmvlG+IbhDQp8ojPA/JbN7l7+VfHD/Lc2ardtxkJWrhhz 5cmN23dyyuos+lNgsvWzEt2ddIyaBD3eYT7sUX823nZJruSB/OMwXaypjjahnw2W05SefR 6+xlBCoL7UEZjFkuyRZLkH8z5dHTzXn3IZUkbYudHdDI7OHjPcEIrFugrG7m9UYSsVVmKp nfA5fylSrefZ/ynqjwSZNYqidtwibUDbXdDPmvFrtZburKn6mjy4R/BWVXHmy/rHV3rve8 bE254sB3Htc7B6LsoEv62vD6v3fFD06woGlVTo/ggpzAV+XZ0rpH4yqy/AEw1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651646706; a=rsa-sha256; cv=none; b=hmrC8TFTbZUEj1fdLURT/azOgLbTPme81d4WFOuBsxHSZeaGixOjql3jPbCcj/MFc8nv98 T+oovwLCgaXHhbkm5IgDdZyviFs/F6x/B805/GlMUNFNEjdW3/I7xtDNphZKkqLTlNpp2V 2AhaxaL1XyZQcIR9Q3Om6T1XNPHLglXjPrfi0W4ArobKGPvQ8Flu8X1yyTpjA5xPwqdImv vtI9Dtob9QaCGEgiDNv3L1rR8sIh+1h35o0/96AwxZmTmhmF1NCRgivvfsI473dKNEe/SY twQmC7qriU4u+t2IB+n4wVEcZcAIRZSgwcp0tZ41F4Oa8DVp4eDJDomX6MJjNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ef7fb0dS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.08 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ef7fb0dS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 359493E9BA X-Spam-Score: -4.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: d3Fg7tm2aT78 Tom Gillespie writes: > It seems that this patch (as commit > 67275f4664ce00b5263c75398d78816e7dc2ffa6, found using git bisect to > hunt down the issue) breaks search in evil mode when > (evil-select-search-module 'evil-search-module 'evil-search) is set. > The broken behavior is that evil-search no longer searches inside > folded headings. I had a quick look at the changes but couldn't figure > out why these changes might cause the issue. Best, Evil re-implements isearch functionality and it does it only partially. It appears to respect isearch-filter-predicate, but not isearch-mode-end-hook. I expect this to be a bug on evil side. Meanwhile, you can try to set search-invisible to t. It should help (in theory). Best, Ihor