From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wHrCDHQKqGLx5gAAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 06:11:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QOO7DHQKqGICRQAA9RJhRA (envelope-from ) for ; Tue, 14 Jun 2022 06:11:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8D8838D27 for ; Tue, 14 Jun 2022 06:11:31 +0200 (CEST) Received: from localhost ([::1]:52242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0xtq-00062U-J7 for larch@yhetil.org; Tue, 14 Jun 2022 00:11:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0xtE-00062H-S1 for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 00:10:52 -0400 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]:38540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0xtD-0000l5-4G for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 00:10:52 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id p31so4553664qvp.5 for ; Mon, 13 Jun 2022 21:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=+RKsy1nXyngkl2j1JmpmfofDU6G2uzrlXvapEhkMH30=; b=f9rVIR471wKBeamgHj4STfld8a7fQOXVJEvylCV1yj2QaoRo2IOExZOdnrR9U4xNtl sT5gg4Z303y/Yg6S24pr9Ev/nMJgMVF8lHK/byMzuy9vLFtuM1ReCGaX04SiQCjSpbH6 KCaW/PldALUexKev2jALpjBgW8RxsVFHu/83aFcIS9FmUujsfkOCscaWK6UN58W/VvBC z498OqNdW0VaEtvIfRvf/Htmi+wWYKHSKDMyjzgGGD3kMtp5586hjXBJlr8NPylO58ex x+ppWrZjY/+iVeFELK0J4NdXwKV5i1R272q6CAZR1/KPnM3ds6lBOriCiQkbXm6y3S2P IENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+RKsy1nXyngkl2j1JmpmfofDU6G2uzrlXvapEhkMH30=; b=Z/q0uBgSz70DZtNK1Ou+AG9aUL8vpzBuFbTN4S40O/IYN71bGuVYy1s2HbdJk1It6l JQ84qqlbK2AAbiuYtbcbTwjX64kEBbcao0RMaAIfhk99E1cUeMEarmALjZqGr8QTn4TL 27VMhNY+/q+h0u0JZCFVuOCVC91MLgZ4XzrHunNBT2CYbhxlGy6dkd/Fm/xMl1r5VraT VYraXArSSlDrCJtBhcKEYNrNUdq3qu9Q+1dfouNcF5DDoqAl4g8ouG5TTtWqd2t1Ae2v Me1anYqhjBLw18YxVdIQrfTrQ+TftLL/k9xuPl0E9iQWwRKX6mGRO9TR9FxsL/ExLSJo L7hw== X-Gm-Message-State: AJIora+KLvbYr/VvlkKAma7/EpRmxCaB5EI0/kPMVbAnMSTqwXBMaqxG KegMwikoKADa+Xi3aCo1smw= X-Google-Smtp-Source: AGRyM1v3O1PQGEnt6FD5LyWCles2hbnn9Pg61yqodyEa2uEVIshPNCDP4J1XdagVfvA1eMCluhD9sA== X-Received: by 2002:a05:6214:4114:b0:46d:c5fa:bf63 with SMTP id kc20-20020a056214411400b0046dc5fabf63mr1955588qvb.13.1655179850077; Mon, 13 Jun 2022 21:10:50 -0700 (PDT) Received: from localhost (22.b2.a86c.ip4.static.sl-reverse.com. [108.168.178.34]) by smtp.gmail.com with ESMTPSA id j9-20020a05622a038900b002f3e127be41sm6634304qtx.20.2022.06.13.21.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 21:10:49 -0700 (PDT) From: Ihor Radchenko To: Ryan Scott Cc: numbchild@gmail.com, Greg Minshall , Timothy , emacs-orgmode@gnu.org Subject: Re: [PATCH] Re: New source block results option for attaching file to node In-Reply-To: References: <981938.1630590273@apollo2.minshall.org> <87czpqjqvw.fsf@localhost> <87zgkey55y.fsf@localhost> <8735i5u039.fsf@localhost> <87h74rq0ql.fsf@localhost> <87czffbc0r.fsf@localhost> Date: Tue, 14 Jun 2022 12:11:59 +0800 Message-ID: <87sfo7q3xs.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=yantar92@gmail.com; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655179891; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+RKsy1nXyngkl2j1JmpmfofDU6G2uzrlXvapEhkMH30=; b=QxuFnvsNhbDzrY8mV8OaKizx4cefDbElP4JmisbnE/0Z7MWCpe+9wywyqSoajQh74ww8fD if0hhLhcKFs/GKab+OfVPJbqDsYWQgf3fAuHAxqyiaCVufmqn+NwqncWZIDRy+QHydHQOd l5m1Z0IohGt65/hgMHaP2DUb14YhFoV8NqYqRLB7HBZKNLoO7TUnW/gl6jN5YFikxYmzd3 kX5V36fcc2h2yH12xkmgNKSpo4yMzi1VQM1CWTNpifiu8arwKU/6sUubFN6muGDYEf5pFu OyUWTrxB/Rz7I0e+dibcmwfziIahKpniW+zgjQiXySe6H9+3I06Esu8oNBZeBg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655179891; a=rsa-sha256; cv=none; b=auTxtdKy8jT2gtf/WdoJG7BNGkwPt6RYFZoy8rkBpqG7AiZc04oOPjelnYC16HAoRXikhq J7qQ9zEXCQzz+CbzNxZKeQ8Xsal9xX5mrKJyC58+4MSwmHT8nQDcS6/ApanN7FKQrdciNn 1QkKH8YaXsDIjLJggOU3aS6Cp7Lh1lu+AAsSaId3UJv/IzMm9C6LQ3trZns27qEjzsLzJg 7ZBM1CK0deK700tErlsLGLIESoIgtrRjXI741Ku5tBNoCl0lwSpiU2YwIYE5JiKuNmSDS/ aSeyjqlmDp1Fgu/cps5v7ROZxcAcDlYXJaU+MR1qysma5mgZc1JE2TNvxBix/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=f9rVIR47; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.59 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=f9rVIR47; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C8D8838D27 X-Spam-Score: -3.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: tGcq0ToMjKcO Ryan Scott writes: > Ah sorry about that. I'm on a windows laptop and didn't have make, so was > testing interactively and they were passing. > I cleaned that up and remove the f-* usage and verified under Ubuntu (on > WSL) that the new tests are passing. I was getting some failures with > unrelated tests, but also get those in master as well. I am still getting test failures using Emacs 28. All the tests are passing on main. Example backtrace: file-name-directory(nil) org-babel-result-to-file("/tmp/test.txt" nil attachment) org-babel-insert-result("/tmp/test.txt" ("replace" "value" "file" "g org-babel-execute-src-block() (progn (org-mode) (let ((point (string-match "" inside-text)) (unwind-protect (progn (org-mode) (let ((point (string-match "#+begin_src shell :results (let ((lexical-binding nil)) (let ((inside-text (if (stringp "\n