From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QLX+EEYq5mJYGAEAbAwnHQ (envelope-from ) for ; Sun, 31 Jul 2022 09:07:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mLTZEEYq5mJ6TgAAauVa8A (envelope-from ) for ; Sun, 31 Jul 2022 09:07:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72FD41841C for ; Sun, 31 Jul 2022 09:07:28 +0200 (CEST) Received: from localhost ([::1]:38552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oI32t-0001xv-8o for larch@yhetil.org; Sun, 31 Jul 2022 03:07:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI31v-0001x5-Ay for emacs-orgmode@gnu.org; Sun, 31 Jul 2022 03:06:27 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:44664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oI31t-0004lg-Jq for emacs-orgmode@gnu.org; Sun, 31 Jul 2022 03:06:27 -0400 Received: by mail-pj1-x1029.google.com with SMTP id e8-20020a17090a280800b001f2fef7886eso8939639pjd.3 for ; Sun, 31 Jul 2022 00:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Ac/oKnDiHdyG60ch7Fijuzr+Odz31SDa+c+LR/PFEcY=; b=ADU6V7WF9r2ULiFWakTBdg51TIMhRM03LUZ8ARp3prMqZK82b9ZlfJmiv8/R5SgV7M Uv9nck10QrxT7hLPrJWW4HtTi62ZcDUp9Eojakoewsp3Kb5+ucrLPQsAFg93nS0K9UEd HDZ9v284p4/fyhodYeLYCgvJlMKk0R879t2UkV8GN07pTXksC7B/zkPMtahQFfAANiqG FbMMNt0vqBBsbiwqhwc49IC7RMqE3cNOX7fIoJusJp3hg7iDkoUJdhgjfD5IIrlOftAq aUycLBsUJbDxphphoEg3k7otQMNUocWP44o6+TGqvP5hEmEQ7RXdeh48s7V95nv9Rc91 EYKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Ac/oKnDiHdyG60ch7Fijuzr+Odz31SDa+c+LR/PFEcY=; b=qD6giKIaUqdJP4BUGLMs6WWCRBAUSzdATXg1hLKGZFNaLYmoKQeiEtTJLybVUJRDx6 qq2wHa7mBV/Huc6veorLli5JO7O7IrtH8jdhmuytB36LvrBLuoKFJQhEvlF80FE8OTSZ 6tWoNbeyNenNGQob5IUGXrvlNqMCujyeo5AYFWpPJNbImB1EDSYmrlJFgwWlzQ8vpgq/ StYpQc0gkIafCLu5vFw1d0lHtOYaixCwJ+m40ilSl/2SnML4UpYLVRcruDJSXnS8Kaai uLS0geX2ziroEePJ6GF/p62dPEjIEB/3YzFU5ZEsazjVNewRc6LnOkjFpNmKi+0lTinv 6L4w== X-Gm-Message-State: ACgBeo23cLeMN5fIfmIf7IbAhAuMsd8vygXs8rPSMGX/GQ3+wmhwnHLu rTzWOFoaELrBqtCGxI/VanI= X-Google-Smtp-Source: AA6agR4rCWFlKe9T9jjCIwkqu4ePECIS7UT/FOwm4RNQrGjWSv9jq1bn997MhJPnVdVuV/DhK05SVA== X-Received: by 2002:a17:902:b402:b0:16c:3cab:5910 with SMTP id x2-20020a170902b40200b0016c3cab5910mr11373842plr.96.1659251184123; Sun, 31 Jul 2022 00:06:24 -0700 (PDT) Received: from localhost ([1.83.155.1]) by smtp.gmail.com with ESMTPSA id k13-20020a170902ce0d00b0016c57657977sm6862238plg.41.2022.07.31.00.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Jul 2022 00:06:23 -0700 (PDT) From: Ihor Radchenko To: Mikhail Skorzhinskii Cc: Org Mode Subject: Re: [PATCH] ox-icalendar.el: create alarm at event time In-Reply-To: <453f362a41c5d9350ce19273048e4808814c9123.camel@eml.cc> References: <875yrbawng.fsf@nicolasgoaziou.fr> <453f362a41c5d9350ce19273048e4808814c9123.camel@eml.cc> Date: Sun, 31 Jul 2022 15:07:24 +0800 Message-ID: <87sfmhn4k3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659251248; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ac/oKnDiHdyG60ch7Fijuzr+Odz31SDa+c+LR/PFEcY=; b=Ks6uA75+tnglI/vgAvKhywdnXGy4cTns4gdeg2ukHPJR+8XhUFNMV+6TT7ZL+k2vmIR+yi zL7UdQF0ti+9y4BMCOKBGYfpXpABC/MdTeNgP5p6EnT7BFIQqiQ8ECedjnW9CGw7oOyDlw EJ8Aw0cAeO9/COzSSsTCYJBIt8i41gXLtKLMoRLIQnuNkkbLLl9tpBhVsCb5JVG0wu1ESq WXr2DjmY7dAHyWzZMsUVu9/WvoL1wInQrHP7Hmdx0RHl6gbflpzdIFDbNTMxhZdQlm0/qQ MkeSUN9ID6z8Yea/3BhCw0MTMLaUIPHA1efJ5+fjdK0EG4HRLFSdkEkNLenJXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659251248; a=rsa-sha256; cv=none; b=D8FGy/cCUH3najJBodQgO2OBudgqP7Vu54IpMN8imnyV3A99eBWVgVj22ItQWGurvQKC0V gc8mUrxRh3DZZjXz1xgOfCwTtGa7nlv04v5AFuC9qVXp2HBM2GNA4edk3X56tBT6HSZQ4z 6xcBuWqIeNptShjZtrxU23vj1K8zVQbnkXpuv8L05AJm4CHUpXSxPzZIRzHZ40XdAsKgf0 g2q2ZNmX8HhQQCugzpQS/Lr7gPOwwTbL1HYWW5klBFPQj2ZWrHagpieotcZoTUIpI3Xgoe 7HE6/2z6r2An8/ZAQvu4byPFmfNpzU6GDb5DOkULPP9HEphKyiuqf/2RAi5VeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ADU6V7WF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.72 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ADU6V7WF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 72FD41841C X-Spam-Score: -6.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: KGp+qOQ5vAGv Mikhail Skorzhinskii writes: > Thank you for the review, appreciate your comments. I've applied your > suggestions. Please find the fixed file in the attachment to this > letter. It took a while, but Applied onto main via 31b3b164d after adding a TINYCHANGE cookie to the commit message (AFAIK, you haven't signed the FSF copyright assignment). https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=31b3b164d100362365bd301d44a838cdf1059109 > There is one important note that about this patch. There is one corner > case: when we've set org-icalendar-force-alarm variable to nil, org- > icalendar-alarm-time variable to non-nil and the APPT_WARNTIME property > is set to 0, then, with my code, the value of the org-icalendar-alarm- > time would be used. > > Basically if user is not forcing the 'zero alarms', and has some non- > zero default value for alarms, the APPT_WARNTIME property will use > default alarm. Which is something, I would say, unexpected. I would > expect that alarm will be shut-off. > > However I am just keeping the previous behaviour. I think its worth > fixing, but I'd say we do this in a separate patch. Sounds reasonable. Feel free to share a patch if you are still interested. However, note that you applied patch is ~15LOC and FSF copyright assignment may be needed. See https://orgmode.org/worg/org-contribute.html#copyright Best, Ihor