From: Ihor Radchenko <yantar92@gmail.com>
To: Mikhail Skorzhinskii <mskorzhinskiy@eml.cc>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ox-icalendar.el: create alarm at event time
Date: Sun, 31 Jul 2022 15:07:24 +0800 [thread overview]
Message-ID: <87sfmhn4k3.fsf@localhost> (raw)
In-Reply-To: <453f362a41c5d9350ce19273048e4808814c9123.camel@eml.cc>
Mikhail Skorzhinskii <mskorzhinskiy@eml.cc> writes:
> Thank you for the review, appreciate your comments. I've applied your
> suggestions. Please find the fixed file in the attachment to this
> letter.
It took a while, but
Applied onto main via 31b3b164d after adding a TINYCHANGE cookie to the
commit message (AFAIK, you haven't signed the FSF copyright assignment).
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=31b3b164d100362365bd301d44a838cdf1059109
> There is one important note that about this patch. There is one corner
> case: when we've set org-icalendar-force-alarm variable to nil, org-
> icalendar-alarm-time variable to non-nil and the APPT_WARNTIME property
> is set to 0, then, with my code, the value of the org-icalendar-alarm-
> time would be used.
>
> Basically if user is not forcing the 'zero alarms', and has some non-
> zero default value for alarms, the APPT_WARNTIME property will use
> default alarm. Which is something, I would say, unexpected. I would
> expect that alarm will be shut-off.
>
> However I am just keeping the previous behaviour. I think its worth
> fixing, but I'd say we do this in a separate patch.
Sounds reasonable. Feel free to share a patch if you are still
interested. However, note that you applied patch is ~15LOC and FSF
copyright assignment may be needed. See
https://orgmode.org/worg/org-contribute.html#copyright
Best,
Ihor
prev parent reply other threads:[~2022-07-31 7:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 15:24 [PATCH] ox-icalendar.el: create alarm at event time Mikhail Skorzhinskii
2021-12-26 21:22 ` Nicolas Goaziou
2021-12-28 12:08 ` Mikhail Skorzhinskii
2022-07-31 7:07 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfmhn4k3.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mskorzhinskiy@eml.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).