* [BUG] Missing definitions for some customization groups [9.5.5 (release_9.5.5 @ /snap/emacs/current/usr/share/emacs/28.2/lisp/org/)]
@ 2022-11-13 16:17 Kyrylo Simonov
2022-11-14 2:42 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: Kyrylo Simonov @ 2022-11-13 16:17 UTC (permalink / raw)
To: emacs-orgmode
Hello,
Some of the customization groups in org-mode lack defgroup declaration.
Specifically, they are:
(org-gnus org-startup org-export-pdf org-bbdb org-babel-tangle
org-bibtex org-plot)
In the *Customize* interface, these subgroups are not accessible from
the main Org customization page and vice versa. To reproduce, type
"M-x customize-group org" and witness that, for example, Org Startup
subgroup is not listed. Then type "M-x customize-group org-startup" and
see that the group definition and the link to the parent group are
missing.
Thank you,
Kyrylo
Emacs : GNU Emacs 28.2 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.20, cairo version 1.16.0)
of 2022-11-03
Package: Org mode version 9.5.5 (release_9.5.5 @
/snap/emacs/current/usr/share/emacs/28.2/lisp/org/)
current state:
==============
(setq
org-link-elisp-confirm-function 'yes-or-no-p
org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3
"\n\n(fn ENTRY)"]
org-export-before-parsing-hook '(org-attach-expand-links)
org-archive-hook '(org-attach-archive-delete-maybe)
org-odt-format-inlinetask-function
'org-odt-format-inlinetask-default-function
org-ascii-format-drawer-function #[771 "\x01\207" [] 4 "\n\n(fn NAME
CONTENTS WIDTH)"]
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-mode-hook '(org-tempo-setup
#[0
"\305\x10\306
>\203\x14\0\307\n\310\311#\210\307\v\312\313#\210\307\v\314\315#\210\306
>\203,\0\307\n\316\317#\210\307\n\320\321#\210\322
>\203>\0\307\v\323\324#\210\307\v\325\324#\210\326
>\203P\0\307\n\327\317#\210\307\n\330\321#\210\331
>\203_\0\332\311\f\333BC\334#\210\335 >\203k\0\332\311\336\334#\210\337
>\203w\0\332\311\340\334#\210\341\342\343\344\311$\210\345\342\311\"\210\342\207"
[org-mouse-context-menu-function
org-mouse-features
org-mouse-map
org-mode-map
org-outline-regexp
org-mouse-context-menu
context-menu
org-defkey
[mouse-3]
nil
[mouse-3]
org-mouse-show-context-menu
[down-mouse-1]
org-mouse-down-mouse
[C-drag-mouse-1]
org-mouse-move-tree
[C-down-mouse-1]
org-mouse-move-tree-start
yank-link
[S-mouse-2]
org-mouse-yank-link
[drag-mouse-3]
move-tree
[drag-mouse-3]
[down-mouse-3]
activate-stars
font-lock-add-keywords
(0
`(face org-link
mouse-face highlight keymap ,org-mouse-map)
'prepend)
t
activate-bullets
(("^[ ]*\\([-+*]\\|[0-9]+[.)]\\) +"
(1
`(face
org-link keymap ,org-mouse-map mouse-face highlight)
'prepend)
)
)
activate-checkboxes
(("^[ ]*\\(?:[-+*]\\|[0-9]+[.)]\\)[
]+\\(?:\\[@\\(?:start:\\)?[0-9]+\\][ ]*\\)?\\(\\[[- X]\\]\\)"
(1
`(face nil keymap ,org-mouse-map mouse-face
highlight)
prepend)
)
)
ad-add-advice
org-open-at-point
(org-mouse-open-at-point
nil
t
(advice
lambda
nil
(let
((context
(org-context)
)
)
(cond
((assq :headline-stars context)
(org-cycle)
)
((assq :checkbox context)
(org-toggle-checkbox)
)
((assq :item-bullet context)
(let
((org-cycle-include-plain-lists t)
)
(org-cycle)
)
)
((org-footnote-at-reference-p)
nil)
(t ad-do-it)
)
)
)
)
around ad-activate]
5]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-show-all append local] 5]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-babel-show-result-all
append local]
5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
org-latex-format-headline-function
'org-latex-format-headline-default-function
org-confirm-shell-link-function 'yes-or-no-p
org-reveal-start-hook '(org-decrypt-entry)
org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME
CONTENTS)"]
outline-isearch-open-invisible-function 'outline-isearch-open-invisible
org-odt-format-headline-function 'org-odt-format-headline-default-function
org-agenda-mode-hook '(#[0
"\302\x10\303 \304\305#\210\303 \306\307#\210\303
\310\311#\210\303 \312\313#\210\303 \314\315#\207"
[org-mouse-context-menu-function
org-agenda-mode-map
org-mouse-agenda-context-menu
org-defkey
[mouse-3]
org-mouse-show-context-menu
[down-mouse-3]
org-mouse-move-tree-start
[C-mouse-4]
org-agenda-earlier
[C-mouse-5]
org-agenda-later
[drag-mouse-3]
#[257
"\300\x01!\211\301\267\202\x11\0\302\303!\207\304\303!\207\305\207"
[org-mouse-get-gesture
#s
(hash-table
size
2
test
eq
rehash-size
1.5
rehash-threshold
0.8125
purecopy
t
data
(:left 9
:right 13)
)
org-agenda-earlier 1 org-agenda-later nil]
4 "\n\n(fn EVENT)" "e"]
]
4]
)
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
org-confirm-elisp-link-function 'yes-or-no-p
org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
org-html-format-inlinetask-function
'org-html-format-inlinetask-default-function
org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
org-latex-format-inlinetask-function
'org-latex-format-inlinetask-default-function
org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-link-shell-confirm-function 'yes-or-no-p
org-babel-pre-tangle-hook '(save-buffer)
org-agenda-loop-over-headlines-in-active-region nil
org-occur-hook '(org-first-headline-recenter)
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-link-parameters '(("eww" :follow org-eww-open :store
org-eww-store-link)
("rmail" :follow org-rmail-open :store org-rmail-store-link)
("mhe" :follow org-mhe-open :store org-mhe-store-link)
("irc" :follow org-irc-visit :store org-irc-store-link
:export org-irc-export)
("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
("gnus" :follow org-gnus-open :store org-gnus-store-link)
("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
("w3m" :store org-w3m-store-link)
("doi" :follow org-link-doi-open :export
org-link-doi-export)
("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
("id" :follow org-id-open) ("file+sys") ("file+emacs")
("shell" :follow org-link--open-shell)
("news" :follow
#[514 "\301\300\302\x04Q\x02\"\207" ["news" browse-url ":"] 6
"\n\n(fn URL ARG)"]
)
("mailto" :follow
#[514 "\301\300\302\x04Q\x02\"\207" ["mailto" browse-url ":"]
6 "\n\n(fn URL ARG)"]
)
("https" :follow
#[514 "\301\300\302\x04Q\x02\"\207" ["https" browse-url ":"] 6
"\n\n(fn URL ARG)"]
)
("http" :follow
#[514 "\301\300\302\x04Q\x02\"\207" ["http" browse-url ":"] 6
"\n\n(fn URL ARG)"]
)
("ftp" :follow
#[514 "\301\300\302\x04Q\x02\"\207" ["ftp" browse-url ":"] 6
"\n\n(fn URL ARG)"]
)
("help" :follow org-link--open-help :store
org-link--store-help)
("file" :complete org-link-complete-file)
("elisp" :follow org-link--open-elisp))
org-html-format-headline-function
'org-html-format-headline-default-function
org-metaup-hook '(org-babel-load-in-session-maybe)
org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [BUG] Missing definitions for some customization groups [9.5.5 (release_9.5.5 @ /snap/emacs/current/usr/share/emacs/28.2/lisp/org/)] 2022-11-13 16:17 [BUG] Missing definitions for some customization groups [9.5.5 (release_9.5.5 @ /snap/emacs/current/usr/share/emacs/28.2/lisp/org/)] Kyrylo Simonov @ 2022-11-14 2:42 ` Ihor Radchenko 2022-11-16 0:01 ` Kyrylo Simonov 0 siblings, 1 reply; 4+ messages in thread From: Ihor Radchenko @ 2022-11-14 2:42 UTC (permalink / raw) To: Kyrylo Simonov; +Cc: emacs-orgmode Kyrylo Simonov <xi@resolvent.net> writes: > Some of the customization groups in org-mode lack defgroup declaration. > Specifically, they are: > (org-gnus org-startup org-export-pdf org-bbdb org-babel-tangle > org-bibtex org-plot) > > In the *Customize* interface, these subgroups are not accessible from > the main Org customization page and vice versa. To reproduce, type > "M-x customize-group org" and witness that, for example, Org Startup > subgroup is not listed. Then type "M-x customize-group org-startup" and > see that the group definition and the link to the parent group are > missing. Confirmed. Would you be interested to create a patch? It is mostly a question of adding a bunch of `defgroup' statements. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] Missing definitions for some customization groups [9.5.5 (release_9.5.5 @ /snap/emacs/current/usr/share/emacs/28.2/lisp/org/)] 2022-11-14 2:42 ` Ihor Radchenko @ 2022-11-16 0:01 ` Kyrylo Simonov 2022-11-16 2:12 ` Ihor Radchenko 0 siblings, 1 reply; 4+ messages in thread From: Kyrylo Simonov @ 2022-11-16 0:01 UTC (permalink / raw) To: emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 950 bytes --] On 11/14/22 02:42, Ihor Radchenko wrote: > Kyrylo Simonov <xi@resolvent.net> writes: > >> Some of the customization groups in org-mode lack defgroup declaration. >> Specifically, they are: >> (org-gnus org-startup org-export-pdf org-bbdb org-babel-tangle >> org-bibtex org-plot) >> >> In the *Customize* interface, these subgroups are not accessible from >> the main Org customization page and vice versa. To reproduce, type >> "M-x customize-group org" and witness that, for example, Org Startup >> subgroup is not listed. Then type "M-x customize-group org-startup" and >> see that the group definition and the link to the parent group are >> missing. > Confirmed. > Would you be interested to create a patch? It is mostly a question of > adding a bunch of `defgroup' statements. I attached a patch. Where it made sense, I added a new defgroup declaration. For other cases, I moved the variables under some existing group. Thanks, Kyrylo [-- Attachment #2: 0001-Fix-missing-customization-groups.patch --] [-- Type: text/x-patch, Size: 7715 bytes --] From 7be0b6eb51748ccf044fffb87020c27fe9dca81e Mon Sep 17 00:00:00 2001 From: Kyrylo Simonov <xi@resolvent.net> Date: Tue, 15 Nov 2022 22:49:56 +0000 Subject: [PATCH] Fix missing customization groups * lisp/ob-tangle.el (org-babel-tangle): Add missing group definition. (org-babel-post-tangle-hook): (org-babel-pre-tangle-hook): (org-babel-tangle-body-hook): (org-babel-tangle-finished-hook): (org-babel-tangle-comment-format-beg): (org-babel-tangle-comment-format-end): (org-babel-tangle-uncomment-comments): (org-babel-process-comment-text): (org-babel-tangle-default-file-mode): Move under `org-babel-tangle' group. * lisp/ol-bbdb.el (org-bbdb-anniversaries): Move under `org-agenda' instead of a non-existent `org-bbdb'. * lisp/ol-bibtex.el (org-bibtex): Add missing group definition. * lisp/ol-gnus.el (org-gnus-no-server): Move under group `org-link-follow' instead of a non-existent `org-gnus'. * lisp/org-plot.el (org-plot): Add missing group definition. * lisp/org.el (org-startup): Add missing group definition. * lisp/ox-latex.el (org-latex-pdf-process): Move under `org-export-latex' instead of a non-existent `org-export-pdf'. * lisp/ox-man.el (org-man-pdf-process): Remove reference to non-existent group `org-export-pdf'. TINYCHANGE --- lisp/ob-tangle.el | 23 ++++++++++++++--------- lisp/ol-bbdb.el | 2 +- lisp/ol-bibtex.el | 5 +++++ lisp/ol-gnus.el | 2 +- lisp/org-plot.el | 5 +++++ lisp/org.el | 5 +++++ lisp/ox-latex.el | 2 +- lisp/ox-man.el | 1 - 8 files changed, 32 insertions(+), 13 deletions(-) diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el index 5074880c4..e86f4e528 100644 --- a/lisp/ob-tangle.el +++ b/lisp/ob-tangle.el @@ -51,6 +51,11 @@ (declare-function outline-previous-heading "outline" ()) (defvar org-id-link-to-org-use-id) ; Dynamically scoped +(defgroup org-babel-tangle nil + "Options for extracting source code from code blocks." + :tag "Org Babel Tangle" + :group 'org-babel) + (defcustom org-babel-tangle-lang-exts '(("emacs-lisp" . "el") ("elisp" . "el")) @@ -73,26 +78,26 @@ then the name of the language is used." (defcustom org-babel-post-tangle-hook nil "Hook run in code files tangled by `org-babel-tangle'." - :group 'org-babel + :group 'org-babel-tangle :version "24.1" :type 'hook) (defcustom org-babel-pre-tangle-hook '(save-buffer) "Hook run at the beginning of `org-babel-tangle' in the original buffer." - :group 'org-babel + :group 'org-babel-tangle :version "24.1" :type 'hook) (defcustom org-babel-tangle-body-hook nil "Hook run over the contents of each code block body." - :group 'org-babel + :group 'org-babel-tangle :version "24.1" :type 'hook) (defcustom org-babel-tangle-finished-hook nil "Hook run at the very end of `org-babel-tangle' in the original buffer. In this way, it is the counterpart to `org-babel-pre-tangle-hook'." - :group 'org-babel + :group 'org-babel-tangle :package-version '(Org . "9.6") :type 'hook) @@ -112,7 +117,7 @@ non-nil value. Whether or not comments are inserted during tangling is controlled by the :comments header argument." - :group 'org-babel + :group 'org-babel-tangle :version "24.1" :type 'string) @@ -132,7 +137,7 @@ non-nil value. Whether or not comments are inserted during tangling is controlled by the :comments header argument." - :group 'org-babel + :group 'org-babel-tangle :version "24.1" :type 'string) @@ -141,7 +146,7 @@ controlled by the :comments header argument." of tangle comments. Use `org-babel-tangle-comment-format-beg' and `org-babel-tangle-comment-format-end' to customize the format of tangled comments." - :group 'org-babel + :group 'org-babel-tangle :type 'boolean) (defcustom org-babel-process-comment-text 'org-remove-indentation @@ -149,7 +154,7 @@ of tangled comments." inserted as comments in tangled source-code files. The function should take a single string argument and return a string result. The default value is `org-remove-indentation'." - :group 'org-babel + :group 'org-babel-tangle :version "24.1" :type 'function) @@ -157,7 +162,7 @@ result. The default value is `org-remove-indentation'." "The default mode used for tangled files, as an integer. The default value 356 correspands to the octal #o544, which is read-write permissions for the user, read-only for everyone else." - :group 'org-babel + :group 'org-babel-tangle :package-version '(Org . "9.6") :type 'integer) diff --git a/lisp/ol-bbdb.el b/lisp/ol-bbdb.el index 7c01c5919..ec1d755e8 100644 --- a/lisp/ol-bbdb.el +++ b/lisp/ol-bbdb.el @@ -135,7 +135,7 @@ (defgroup org-bbdb-anniversaries nil "Customizations for including anniversaries from BBDB into Agenda." - :group 'org-bbdb) + :group 'org-agenda) (defcustom org-bbdb-default-anniversary-format "birthday" "Default anniversary class." diff --git a/lisp/ol-bibtex.el b/lisp/ol-bibtex.el index d8547f316..313b1cde8 100644 --- a/lisp/ol-bibtex.el +++ b/lisp/ol-bibtex.el @@ -236,6 +236,11 @@ (defvar org-bibtex-entries nil "List to hold parsed bibtex entries.") +(defgroup org-bibtex nil + "Options for translating between Org headlines and BibTeX entries." + :tag "Org BibTeX" + :group 'org) + (defcustom org-bibtex-autogen-keys nil "Set to a truth value to use `bibtex-generate-autokey' to generate keys." :group 'org-bibtex diff --git a/lisp/ol-gnus.el b/lisp/ol-gnus.el index a7bb65555..185218ab7 100644 --- a/lisp/ol-gnus.el +++ b/lisp/ol-gnus.el @@ -74,7 +74,7 @@ negates this setting for the duration of the command." (defcustom org-gnus-no-server nil "Should Gnus be started using `gnus-no-server'?" - :group 'org-gnus + :group 'org-link-follow :version "24.4" :package-version '(Org . "8.0") :type 'boolean) diff --git a/lisp/org-plot.el b/lisp/org-plot.el index 9665a9e68..ef6b5aa05 100644 --- a/lisp/org-plot.el +++ b/lisp/org-plot.el @@ -294,6 +294,11 @@ When NORMALIZE is non-nil, the count is divided by the number of values." )) (cl-subseq factors 0 -1))) +(defgroup org-plot nil + "Options for plotting in Org mode." + :tag "Org Plot" + :group 'org) + (defcustom org-plot/gnuplot-script-preamble "" "String of function to be inserted before the gnuplot plot command is run. diff --git a/lisp/org.el b/lisp/org.el index 7aaef06f0..857c3147c 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -977,6 +977,11 @@ equivalent option for agenda views." :group 'org-todo :group 'org-archive) +(defgroup org-startup nil + "Startup options Org uses when first visiting a file." + :tag "Org Startup" + :group 'org) + (defcustom org-startup-folded 'showeverything "Non-nil means entering Org mode will switch to OVERVIEW. diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el index 9bdb9fb63..b5f81fe53 100644 --- a/lisp/ox-latex.el +++ b/lisp/ox-latex.el @@ -1440,7 +1440,7 @@ Alternatively, this may be a Lisp function that does the processing, so you could use this to apply the machinery of AUCTeX or the Emacs LaTeX mode. This function should accept the file name as its single argument." - :group 'org-export-pdf + :group 'org-export-latex :type '(choice (repeat :tag "Shell command sequence" (string :tag "Shell command")) diff --git a/lisp/ox-man.el b/lisp/ox-man.el index 339ab11cd..111c46aed 100644 --- a/lisp/ox-man.el +++ b/lisp/ox-man.el @@ -226,7 +226,6 @@ By default, Org uses 3 runs of to do the processing. Alternatively, this may be a Lisp function that does the processing. This function should accept the file name as its single argument." - :group 'org-export-pdf :group 'org-export-man :version "24.4" :package-version '(Org . "8.0") -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [BUG] Missing definitions for some customization groups [9.5.5 (release_9.5.5 @ /snap/emacs/current/usr/share/emacs/28.2/lisp/org/)] 2022-11-16 0:01 ` Kyrylo Simonov @ 2022-11-16 2:12 ` Ihor Radchenko 0 siblings, 0 replies; 4+ messages in thread From: Ihor Radchenko @ 2022-11-16 2:12 UTC (permalink / raw) To: Kyrylo Simonov; +Cc: emacs-orgmode Kyrylo Simonov <xi@resolvent.net> writes: >> Confirmed. >> Would you be interested to create a patch? It is mostly a question of >> adding a bunch of `defgroup' statements. > > I attached a patch. Where it made sense, I added a new defgroup > declaration. For other cases, I moved the variables under some > existing group. Thanks! Applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=00778ce2a You are now also listed as an Org contributor. https://git.sr.ht/~bzg/worg/commit/9f330e70 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-16 2:13 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-13 16:17 [BUG] Missing definitions for some customization groups [9.5.5 (release_9.5.5 @ /snap/emacs/current/usr/share/emacs/28.2/lisp/org/)] Kyrylo Simonov 2022-11-14 2:42 ` Ihor Radchenko 2022-11-16 0:01 ` Kyrylo Simonov 2022-11-16 2:12 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).