Incorrect numbering of tables (and other elements like figures) [Org 9.6]

Incorrect numbering of tables (and other elements like figures) [Org 9.6]

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

Hello,

Since Org 9.6, I am seeing that the numbering of tables (and other elements
like figures) resets to 1 and stays so, thought I cannot see a pattern of
why that happens.

Org version: Org mode version 9.6 (release_9.6-40-g49cf3e ..)

Here's a small reproducible example that shows the problem in any exporter
(ox-ascii, ox-html, ..)

=====
#+title: Table numbering test
#+options: author:nil toc:nil

#+caption: Should be Table 1
| h1       | h2       | h3       |
|----------+----------+----------|
| abcdefgh | ijklmnop | qrstuvwx |

#+caption: Should be Table 2
| h1       | h2       | h3       |
|----------+----------+----------|
| abcdefgh | ijklmnop | qrstuvwx |

#+caption: Should be Table 3
| h1       | h2       | h3       |
|----------+----------+----------|
| abcdefgh | ijklmnop | qrstuvwx |

#+caption: Should be Table 4
| h1       | h2       | h3       |
|----------+----------+----------|
| abcdefgh | ijklmnop | qrstuvwx |
=====

Output of C-c C-e t A:

=====
                         ______________________

                          TABLE NUMBERING TEST
                         ______________________


 h1        h2        h3
------------------------------
 abcdefgh  ijklmnop  qrstuvwx
Table 1: Should be Table 1

 h1        h2        h3
------------------------------
 abcdefgh  ijklmnop  qrstuvwx
Table 2: Should be Table 2

 h1        h2        h3
------------------------------
 abcdefgh  ijklmnop  qrstuvwx
Table 1: Should be Table 3

 h1        h2        h3
------------------------------
 abcdefgh  ijklmnop  qrstuvwx
Table 1: Should be Table 4
=====



--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2339 bytes --]

Re: Incorrect numbering of tables (and other elements like figures) [Org 9.6]

[Ihor Radchenko]

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Since Org 9.6, I am seeing that the numbering of tables (and other elements
> like figures) resets to 1 and stays so, thought I cannot see a pattern of
> why that happens.
>
> Org version: Org mode version 9.6 (release_9.6-40-g49cf3e ..)
>
> Here's a small reproducible example that shows the problem in any exporter
> (ox-ascii, ox-html, ..)
> ...

Thanks for reporting!
Fixed on bugfix. With a test now.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bdb4c4c66
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=02909fe37

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Incorrect numbering of tables (and other elements like figures) [Org 9.6]

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

On Tue, Dec 13, 2022 at 3:52 AM Ihor Radchenko <yantar92@posteo.net> wrote:

> Kaushal Modi <kaushal.modi@gmail.com> writes:
>
> > Since Org 9.6, I am seeing that the numbering of tables (and other
> elements
> > like figures) resets to 1 and stays so, thought I cannot see a pattern of
> > why that happens.
> >
> > Org version: Org mode version 9.6 (release_9.6-40-g49cf3e ..)
> >
> > Here's a small reproducible example that shows the problem in any
> exporter
> > (ox-ascii, ox-html, ..)
> > ...
>
> Thanks for reporting!
> Fixed on bugfix. With a test now.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bdb4c4c66
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=02909fe37
>
>
Thank you!

I confirm the fix. Also thanks for adding the test.

[-- Attachment #2: Type: text/html, Size: 1498 bytes --]

Request to bump up the Org version in Elpa [ Was: Incorrect numbering of tables (and other elements like figures) ]

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Hello,

Can a new version of Org be tagged from the bugfix branch?

The below-reported bug was fixed quickly but the Elpa version of Org
doesn't yet see that fix.

My ox-hugo package uses the Elpa version of Org mode for the tests on
Github Actions, so my test suite has been failing for quite some time.

I believe that for Elpa, the only way to update the version is to update
the version in the package's comment header.

--
Kaushal Modi


On Tue, Dec 13, 2022 at 3:51 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> On Tue, Dec 13, 2022 at 3:52 AM Ihor Radchenko <yantar92@posteo.net>
> wrote:
>
>> Kaushal Modi <kaushal.modi@gmail.com> writes:
>>
>> > Since Org 9.6, I am seeing that the numbering of tables (and other
>> elements
>> > like figures) resets to 1 and stays so, thought I cannot see a pattern
>> of
>> > why that happens.
>> >
>> > Org version: Org mode version 9.6 (release_9.6-40-g49cf3e ..)
>> >
>> > Here's a small reproducible example that shows the problem in any
>> exporter
>> > (ox-ascii, ox-html, ..)
>> > ...
>>
>> Thanks for reporting!
>> Fixed on bugfix. With a test now.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bdb4c4c66
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=02909fe37
>>
>>
> Thank you!
>
> I confirm the fix. Also thanks for adding the test.
>

[-- Attachment #2: Type: text/html, Size: 2559 bytes --]

Re: Request to bump up the Org version in Elpa [

[Bastien Guerry]

Hi Kaushal,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Can a new version of Org be tagged from the bugfix branch?

Ihor, if you agree, I can release Org 9.6.1 today.

We can continue to work on Org 9.6.2 for later merge in Emacs.

The problem with `org-assert-version' can be dealt with later
on, even if many users will perhaps expect something for 9.6.1.

WDYT?

-- 
 Bastien

Re: Request to bump up the Org version in Elpa [

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

>> Can a new version of Org be tagged from the bugfix branch?
>
> Ihor, if you agree, I can release Org 9.6.1 today.
>
> We can continue to work on Org 9.6.2 for later merge in Emacs.
>
> The problem with `org-assert-version' can be dealt with later
> on, even if many users will perhaps expect something for 9.6.1.
>
> WDYT?

+1

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Request to bump up the Org version in Elpa [

[Bastien]

Ihor Radchenko <yantar92@posteo.net> writes:

> +1

Done, thanks.

Kaushal, it should appear on GNU ELPA in a few hours.

Ihor, feel free to publish bugfix releases with no special permission
in the future.

-- 
 Bastien

Re: Request to bump up the Org version in Elpa [

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On Wed, Jan 11, 2023 at 10:50 AM Bastien <bzg@gnu.org> wrote:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
> > +1
>
> Done, thanks.
>
> Kaushal, it should appear on GNU ELPA in a few hours.
>

Wow, thanks a lot for this prompt action! This will help get the Github
Actions CI status back in green state.. soon :).


> Ihor, feel free to publish bugfix releases with no special permission
> in the future.
>

[-- Attachment #2: Type: text/html, Size: 929 bytes --]

Re: Request to bump up the Org version in Elpa [

[Ihor Radchenko]

Bastien <bzg@gnu.org> writes:

> Kaushal, it should appear on GNU ELPA in a few hours.

Already there.

> Ihor, feel free to publish bugfix releases with no special permission
> in the future.

Noted, thanks!

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>