From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yO5POpjGx2NWLQAAbAwnHQ (envelope-from ) for ; Wed, 18 Jan 2023 11:14:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GKZYOZjGx2PIsAAAG6o9tA (envelope-from ) for ; Wed, 18 Jan 2023 11:14:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EC2311FBC for ; Wed, 18 Jan 2023 11:14:48 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI5SZ-0002vw-N3; Wed, 18 Jan 2023 05:14:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI5SV-0002tS-Nw for emacs-orgmode@gnu.org; Wed, 18 Jan 2023 05:14:19 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI5SS-0008UB-U6 for emacs-orgmode@gnu.org; Wed, 18 Jan 2023 05:14:19 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0BD402402F6 for ; Wed, 18 Jan 2023 11:14:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1674036855; bh=8KiyaWuUA9jzfc+g+GQJ6Xe4b/cD5NyRO2a0KPFNKto=; h=From:To:Cc:Subject:Date:From; b=lTEb28mgIQzaHfqP1+yvFp+yOW0+S4/kOxXAQbVoQlLEAhJV7DBP9ieF/qHDInRdD jkuVl5Uj68BWEtCPG6Xx4v2w/w53sy127JVGpFTOcVk5f9kLz54bx39TscU98NXZ8R fJYgKP3T9eBhTDtVEUErHiKmZj2botful80MIBfhCXDhe5fMxR5u6rkkXb8mtL2YPt 2Wfp4BGzIPgnE94eGKobASWHt0WqEWoD1GtlyOJaTe2Tj7z3ed/VqZP0QYZCsKw2u7 knvN6ZzDiGJb+axk2twJuJuQIyGQtkc92O0Oth8DCqfhrNnnlvHDSjt25fwQ6ep09g Y0RDjl0wI6g3w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NxhSP6zjXz9rxN; Wed, 18 Jan 2023 11:14:13 +0100 (CET) From: Ihor Radchenko To: Samuel Wales Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH 0/4] Structure editing when region is active In-Reply-To: References: <87zgailod7.fsf@localhost> <87ilh5ijdk.fsf@localhost> Date: Wed, 18 Jan 2023 10:14:46 +0000 Message-ID: <87sfg86tex.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674036888; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=orYrSRLlQJ0A8lqW4Jiv5uB7CtSxyykwWqA3WZdOwZg=; b=m4pYXYWJqHp2bFE/NOlDCA22z/MivUt58AsGSBwjSQv5j/GmnolKDnV9/cfmM/PdEfg2/c ey3sr9rLcN2veRky5iY4nEVD2TinxsEA6q0xTRNZrLKXx8aM3S9cA1a+TWaaQzv7+OM0NM rIQUuRdHhlL0Mze4ux3V9jFlNUrXQUQe4oqjJxlES0RhCRn1g6ruocL+NajHy0OGuSBdYc SW33x2OIgKWBt4GMUn4d6y38e+MA73o+vBrNP0tWp8lEKjPjHHMTV6uVlbdS8FwyOIdoaz e15hNZKfZFn59wkef0pWVkgaBtpvrj7TnkTs03lbi2tSGCbsYTguuD10JOzz2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lTEb28mg; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674036888; a=rsa-sha256; cv=none; b=Pqgm1OW5OeR6gIQW+79MlZ/Ppz3xtSURatwAHT+t2f00g6nq6Yzk6XOssGz14iLu0bW83n mYLFfEPvR7B7Xy9PkNvkmbGWyZ7EI3DhGfgtj6cLe83WDYy53O0Rnu4KcdQTuJuBvpLsp1 wrFPolLNPwK2Ptrq1NPkRUTek2VFGECsaguE1WLDTbE5OJdt00Hu6o0Ydf7DY637A7SHkS udEjkOyi2UdCVmWy69MbFL0c0auNNmlooV8lCl/eG9PgzyCRy4NyJeXkkVWa2nzQXifBN/ sTsiEfQuJ50t2Khgt0d6mq2Ak7x+pgUh9/D+MjQFrdMqYrB/QpJVpnDeC1AYOg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.58 X-Spam-Score: -4.58 X-Migadu-Queue-Id: 9EC2311FBC Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lTEb28mg; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: ND4D6XzVP9ff Samuel Wales writes: > maybe my comment is too unrelated to the patch, but it just seemed > worth raising in the context. to me it feels wrong to have a > non-linline-task child entry whose heading is star-indented more > levels than needed to denote a child entry. > > in my own case, it suggests corruption, because i would not > deliberately create that. i have encountered it. similarly if > org-odd-levels-only is non-nil and there is an even star heading. i > have encountered it. confusing to track down. > > i was merely asking if there was anything in e.g. main or syntax > documents etc. that refers to or enforces this. I have seen some checks in the code to ensure not breaking structure. They may not be ideal, indeed. Hard to say much without a reproducer. > as for active region or transient mark, to me, they are supposed to be > transient, unlike, for example, agenda restriction lock, and thus, for > example, having to c-g or so to get rid of a highlighted region feels > like a bug. > > there might be exceptions where you pretty much always want to run a > command more than once with the region remaining active, perhaps such > as a rectange opening type of command, but to me the patch commands do > not apply there. The patch is mostly aiming at M-arrow commands. I feel like M-arrow are issued repeatedly quite often. We may also provide a defcustom. Though I will be in favour of keeping "do not deactivate selection" as the default of such defcustom. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at