From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GKPIHIJw9WXzdgEA62LTzQ:P1 (envelope-from ) for ; Sat, 16 Mar 2024 11:12:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id GKPIHIJw9WXzdgEA62LTzQ (envelope-from ) for ; Sat, 16 Mar 2024 11:12:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gEn1zS2F; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710583938; a=rsa-sha256; cv=none; b=B3/3Va7L+xE0CACFS46tYvofWFCSYB3UlNTfGftgu67d2KQtSRyH6caePKGg9HasIDc5+R gOK0LMTQUQjzo8eWrcBebNiwnJ9ILe9YmIIaWJqtP/T98tMIbYgnfFAtc/nKjKDQo8YOXB mvcNwTTQTPwJRa8m8WKdslWGbxQqMEd4vW3f40sC6ulFq8Z2pNq8IhZLp3bO9+A+N/uNDx nGGTDvaCr768hBt51GFo6nHN2wL8qKgpJ21NweHGmpScQpLFOATwCfDdlC+/YhnAsJlr3E nUzBykmq98fFYcmWXKgK/o4u1C8IFbPMGCss8goIgAllAPO1ofMJ4/35Cfb1RA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gEn1zS2F; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710583938; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RTE1DL3zPIaAYMpNLrFujnFQ73PQdgNfC8ESeChBjKc=; b=T3uKtEijVH9JlcBc3+MziM7pu0JF9tSsptFW2w4K7hG6C8qDjRcoTl5VHIK2WLYUxFiZXP ETdLt+WOmlcGsd0C64aMfTQiIIuq5LJOK0P3W+9bkLOlCygdgt69WRIsAp0+H97NPHlnMd I3q9YnELOqvJnx3IeZSRUVL45bPt5bcO9czPX668GFI7ShaUwGUi417+SpuYeEgZpp8n4o Fwd6ZLzmylgF6/8wM98aSjGMZKn0Qpcn8yLaDWORLa7yw9f7ucvzGUsIVvaGA5hawuBGsS kEWSlm35rfgG3FkRBMolCA/oyoI1LQwmZP1X/MruRuRkr7rI9q5cFgAMZQx/0g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21BA426BCD for ; Sat, 16 Mar 2024 11:12:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlR19-0005CU-6V; Sat, 16 Mar 2024 06:11:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlR16-0005C5-Uo for emacs-orgmode@gnu.org; Sat, 16 Mar 2024 06:11:52 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlR0z-0006q5-OI for emacs-orgmode@gnu.org; Sat, 16 Mar 2024 06:11:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 818DD240027 for ; Sat, 16 Mar 2024 11:11:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1710583902; bh=HGH9xdGfBzdeqwACzSig2Rb39AGhWnH7KyFR8YxvTE0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=gEn1zS2FSne+RuwNhBHuwXHwlT4/aNihLwRWTkV2YAVf8CNfuXqHaVets8ebvOqvT Ke2hiVG3LJeuW8HJrAF7dAhdbcAS3DblbXPqtmDIXApyZTpxR1QqA0Hu08sywNHNiJ 6h9yq/141vAtGCCFnh9qUOx+5J5MnkZaGazjPVD0Ajt5AsAVOGlojh9N9WB3jTIvcQ 8Ltdgbx88vNwnRoIMgu99wSl9y77z6PhWjKGxk7Jx9gkiZM/kDKYG/jOIQQ0Qgqm6G ipkVietRy7qfXfWOb5K8yOryS8C0H8D/ZLo/FtfpH1wsT9zDqEKA7Nej3Fb+XHJe82 Z3i3lydPmVAzA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TxcNF66wYz9rxD; Sat, 16 Mar 2024 11:11:41 +0100 (CET) From: Ihor Radchenko To: Matt Cc: "Aaron L. Zeng" , emacs-orgmode Subject: Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name In-Reply-To: <18e440cec8c.d2bfc741504486.3314999848804225927@excalamus.com> References: <20240311051313.3490020-1-me@bcc32.com> <18e2ef220a9.b5a8c7ae44361.2739966878741459645@excalamus.com> <87jzm7d1du.fsf@localhost> <18e440cec8c.d2bfc741504486.3314999848804225927@excalamus.com> Date: Sat, 16 Mar 2024 10:11:38 +0000 Message-ID: <87sf0qiizp.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.46 X-Spam-Score: -9.46 X-Migadu-Queue-Id: 21BA426BCD X-TUID: iLD7Zxr/IXYY Matt writes: > Finally had time to commit it. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0e2a9524dc6da8b4d60672e85aba74076baac211 Thanks! I notice that you changed the commit author and only referenced Aaron in Submitted By: metadata. For future, we prefer keeping the original commit author in the "author" field of the commits - this is important to keep track of the number of changed lines for contributors without FSF copyright assignment. You may consider using https://git.kyleam.com/piem/about/ to apply patches submitted as emails automatically. Or you can assign the commit author manually, using -A git commit switch (magit also provides a transient menu option for this). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at