From: Ihor Radchenko <yantar92@posteo.net>
To: Al Haji-Ali <abdo.haji.ali@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]
Date: Mon, 17 Jun 2024 17:26:53 +0000 [thread overview]
Message-ID: <87sexba3aa.fsf@localhost> (raw)
In-Reply-To: <m2ed8vr2io.fsf@gmail.com>
Al Haji-Ali <abdo.haji.ali@gmail.com> writes:
> I have `org-refile-use-outline-path` set to t, expecting that when refiling, the filename should not appear in the list. However, because I am opening an org file using a symblink and I have `find-file-visit-truename` set to `t`, the test
>
> `(not (equal filename (nth 1 x)))`
>
> in `org-refile-get-location` always fails and the filename is displayed even when the current buffer and `(nth 1 x)` point to the same file. If I replace this condition by
>
> `(not (equal (file-truename filename) (file-truename (nth 1 x))))`
>
> The filename is not added to the list of refile targets as I would expect.
Makes sense.
May you prepare a patch with the proposed change?
See https://orgmode.org/worg/org-contribute.html#first-patch
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-06-17 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 15:51 [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)] Al Haji-Ali
2024-06-17 17:26 ` Ihor Radchenko [this message]
2024-06-17 21:52 ` Al Haji-Ali
2024-06-18 12:56 ` Ihor Radchenko
2024-06-18 18:53 ` Al Haji-Ali
2024-06-19 14:25 ` Ihor Radchenko
2024-06-20 8:00 ` Al Haji-Ali
2024-06-20 14:56 ` Ihor Radchenko
2024-06-20 15:13 ` Al Haji-Ali
2024-06-20 15:26 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sexba3aa.fsf@localhost \
--to=yantar92@posteo.net \
--cc=abdo.haji.ali@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).