emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
@ 2024-11-29 16:26 Suhail Singh
  2024-12-02 15:23 ` Max Nikulin
  2024-12-05 15:44 ` Max Nikulin
  0 siblings, 2 replies; 7+ messages in thread
From: Suhail Singh @ 2024-11-29 16:26 UTC (permalink / raw)
  To: emacs-orgmode

* org-contrib/babel/languages/ob-doc-gnuplot.org (Introduction): Fix
link to source.
---
 org-contrib/babel/languages/ob-doc-gnuplot.org | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org-contrib/babel/languages/ob-doc-gnuplot.org b/org-contrib/babel/languages/ob-doc-gnuplot.org
index 4bcca41d..d51102d2 100644
--- a/org-contrib/babel/languages/ob-doc-gnuplot.org
+++ b/org-contrib/babel/languages/ob-doc-gnuplot.org
@@ -34,7 +34,7 @@ * Introduction
 usage. Since babel is simply allowing native code to run inside of
 Org-mode, all gnuplot documentation is applicable and valid. [fn:1]
 
-This file may be downloaded here: [[https://orgmode.org/worg/sources/org-contrib/babel/examples/org-babel-gnuplot.org][org-babel-gnuplot.org]]. The image
+This file may be downloaded here: [[https://orgmode.org/worg/org-contrib/babel/examples/org-babel-gnuplot.org][org-babel-gnuplot.org]]. The image
 links are to the images online on Worg, but running the code blocks
 will produce matching images in the same directory as the .org file.
 

base-commit: db73ab050bd884bdc7a062aeb9042f5e659854ff


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
  2024-11-29 16:26 [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source Suhail Singh
@ 2024-12-02 15:23 ` Max Nikulin
  2024-12-02 19:32   ` Suhail Singh
  2024-12-05 15:44 ` Max Nikulin
  1 sibling, 1 reply; 7+ messages in thread
From: Max Nikulin @ 2024-12-02 15:23 UTC (permalink / raw)
  To: emacs-orgmode

On 29/11/2024 23:26, Suhail Singh wrote:
> -This file may be downloaded here: [[https://orgmode.org/worg/sources/org-contrib/babel/examples/org-babel- 
> gnuplot.org][org-babel-gnuplot.org]]. The image
> +This file may be downloaded here: [[https://orgmode.org/worg/org-contrib/babel/examples/org-babel-gnuplot.org][org-babel-gnuplot.org]]. The image

Thanks.

I am in doubts what kind of links should be used. Bastien committed a 
lot of git.sr.ht links:
https://git.sr.ht/~bzg/worg/commit/e26fa7ba00#org-contrib/babel/uses.org

I expected to find a macro for this purpose, but it seems there is no one.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
  2024-12-02 15:23 ` Max Nikulin
@ 2024-12-02 19:32   ` Suhail Singh
  2024-12-03 17:11     ` Max Nikulin
  0 siblings, 1 reply; 7+ messages in thread
From: Suhail Singh @ 2024-12-02 19:32 UTC (permalink / raw)
  To: Max Nikulin; +Cc: emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> I am in doubts what kind of links should be used. Bastien committed a lot of
> git.sr.ht links:
> https://git.sr.ht/~bzg/worg/commit/e26fa7ba00#org-contrib/babel/uses.org
>
> I expected to find a macro for this purpose, but it seems there is no one.

Yes, either macros or link abbreviations would help in this regard.
It's on my list of things to submit patches for when I get around to it,
unless someone else beats me to it.

For now, I simply wanted to ensure the link was no longer broken.  Feel
free to discard the patch in favor of another that addresses the issue
generically.

-- 
Suhail


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
  2024-12-02 19:32   ` Suhail Singh
@ 2024-12-03 17:11     ` Max Nikulin
  2024-12-10 19:25       ` Ihor Radchenko
  0 siblings, 1 reply; 7+ messages in thread
From: Max Nikulin @ 2024-12-03 17:11 UTC (permalink / raw)
  To: emacs-orgmode

On 03/12/2024 02:32, Suhail Singh wrote:
> Max Nikulin writes:
> 
> For now, I simply wanted to ensure the link was no longer broken.  Feel
> free to discard the patch in favor of another that addresses the issue
> generically.

I have pushed a commit changing worg/sources/ links to git.sr.ht in 3 
files. Accordingly to

git grep --count \
     '\[https://git\.sr\.ht/~bzg/worg/tree/master/item/[^]]*\.org\]'
git grep --count '\[https://orgmode.org/[^]]*\.org\]'

the former used more often. HTML files will be updated when Ihor push 
some changes next time.

I recall a discussion whether a link to source file should be added to 
every worg page.

Cancelled.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
  2024-11-29 16:26 [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source Suhail Singh
  2024-12-02 15:23 ` Max Nikulin
@ 2024-12-05 15:44 ` Max Nikulin
  2024-12-10 15:09   ` Suhail Singh
  1 sibling, 1 reply; 7+ messages in thread
From: Max Nikulin @ 2024-12-05 15:44 UTC (permalink / raw)
  To: emacs-orgmode

On 29/11/2024 23:26, Suhail Singh wrote:
> +++ b/org-contrib/babel/languages/ob-doc-gnuplot.org
> @@ -34,7 +34,7 @@ * Introduction
>   usage. Since babel is simply allowing native code to run inside of
>   Org-mode, all gnuplot documentation is applicable and valid. [fn:1]
>   
> -This file may be downloaded here: [[https://orgmode.org/worg/sources/org-contrib/babel/examples/org-babel- 
> gnuplot.org][org-babel-gnuplot.org]]. The image

I have realized that ob-doc-gnuplot.org and org-babel-gnuplot.org files 
are quite similar. The latter have not got some recent update though. I 
think, the former may use noweb to have source code blocks active while 
using the same content for exporting with header arguments. Are there 
any other reason why duplicated content exists? I would drop one file to 
avoid divergence.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
  2024-12-05 15:44 ` Max Nikulin
@ 2024-12-10 15:09   ` Suhail Singh
  0 siblings, 0 replies; 7+ messages in thread
From: Suhail Singh @ 2024-12-10 15:09 UTC (permalink / raw)
  To: Max Nikulin; +Cc: emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> I have realized that ob-doc-gnuplot.org and org-babel-gnuplot.org files are
> quite similar.

Good catch!

The latter have not got some recent update though. I think, the
> former may use noweb to have source code blocks active while using the same
> content for exporting with header arguments.

> Are there any other reason why duplicated content exists? I would drop
> one file to avoid divergence.

Looking briefly into it, it's not clear to me that the inclusion of
org-babel-gnuplot.org in commit 394a6326881fc1f077ca8f4b891d8f133f80d305
wasn't an accident.

It might make sense to include an examples/plotting.org at some point,
with very different content.  But as things stand today I believe of the
two files ob-doc-gnuplot.org is the one that should be retained and if
there's any meaningful information contained in org-babel-gnuplot.org
which isn't yet in ob-doc-gnuplot.org that it should be assimilated into
ob-doc-gnuplot.org.

PS: please include my address in replies.

-- 
Suhail


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source.
  2024-12-03 17:11     ` Max Nikulin
@ 2024-12-10 19:25       ` Ihor Radchenko
  0 siblings, 0 replies; 7+ messages in thread
From: Ihor Radchenko @ 2024-12-10 19:25 UTC (permalink / raw)
  To: Max Nikulin; +Cc: emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> On 03/12/2024 02:32, Suhail Singh wrote:
>> Max Nikulin writes:
>> 
>> For now, I simply wanted to ensure the link was no longer broken.  Feel
>> free to discard the patch in favor of another that addresses the issue
>> generically.
>
> I have pushed a commit changing worg/sources/ links to git.sr.ht in 3 
> files. Accordingly to
>
> git grep --count \
>      '\[https://git\.sr\.ht/~bzg/worg/tree/master/item/[^]]*\.org\]'
> git grep --count '\[https://orgmode.org/[^]]*\.org\]'
>
> the former used more often. HTML files will be updated when Ihor push 
> some changes next time.

Ideally, we want to use a simple [[./file.org]] links. But it is
actually tricky because of `org-html-link-org-files-as-html'.
So, direct http link has to do for now.

> I recall a discussion whether a link to source file should be added to 
> every worg page.

Do you have a link to that discussion?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-12-10 19:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-29 16:26 [PATCH worg v2] ob-doc-gnuplot.org: Fix broken link to source Suhail Singh
2024-12-02 15:23 ` Max Nikulin
2024-12-02 19:32   ` Suhail Singh
2024-12-03 17:11     ` Max Nikulin
2024-12-10 19:25       ` Ihor Radchenko
2024-12-05 15:44 ` Max Nikulin
2024-12-10 15:09   ` Suhail Singh

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).