Setting org-id-track-globally to nil results in "Wrong argument type: hash-table-p, nil" in org-id-find-id-file

Setting org-id-track-globally to nil results in "Wrong argument type: hash-table-p, nil" in org-id-find-id-file

[Geralt]

Hi,

the following test-case reproduces the above message:
emacs -q
(setq org-id-track-globally nil)
// Open a file using IDs and a link to at least one of those headings
(require 'org-id)
// Now try to follow an id-link




A sample org-file with an id:
* An item
  :PROPERTIES:
  :ID:       0fb1cfdb-7bf7-4d8f-95b3-2e50e4d23537
  :END:

* A link
  [[id:0fb1cfdb-7bf7-4d8f-95b3-2e50e4d23537][An item]]




The exact error-message is:
org-id-find-id-file: Wrong type argument: hash-table-p, nil




HTH,

Geralt.

Re: Setting org-id-track-globally to nil results in "Wrong argument type: hash-table-p, nil" in org-id-find-id-file

[Geralt]

Hi,

can nobody else reproduce my problem? btw. I forgot to mention that
I'm using Emacs 23.1.1 and Orgmode 6.21b



Geralt.

Re: Re: Setting org-id-track-globally to nil results in "Wrong argument type: hash-table-p, nil" in org-id-find-id-file

[David Maus]

[-- Attachment #1.1.1: Type: text/plain, Size: 447 bytes --]

Geralt wrote:
>can nobody else reproduce my problem? btw. I forgot to mention that
>I'm using Emacs 23.1.1 and Orgmode 6.21b

I could reproduce it and attached is a fix.

The problem was, that the function that queries the global id database
did not take in account `org-id-locations' beeing set to nil (i.e.:
global database disabled).

HTH
 -- David

--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... maus.david@gmail.com

[-- Attachment #1.1.2: org-fix-org-id-find-id-file.patch --]
[-- Type: application/octet-stream, Size: 595 bytes --]

diff --git a/lisp/org-id.el b/lisp/org-id.el
index 6f27287..d96d2d7 100644
--- a/lisp/org-id.el
+++ b/lisp/org-id.el
@@ -545,7 +545,7 @@ When CHECK is given, prepare detailed information about duplicate IDs."
 (defun org-id-find-id-file (id)
   "Query the id database for the file in which this ID is located."
   (unless org-id-locations (org-id-locations-load))
-  (or (gethash id org-id-locations)
+  (or (and org-id-locations (gethash id org-id-locations))
       ;; ball back on current buffer
       (buffer-file-name (or (buffer-base-buffer (current-buffer))
 			    (current-buffer)))))

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Re: Setting org-id-track-globally to nil results in "Wrong argument type: hash-table-p, nil" in org-id-find-id-file

[Carsten Dominik]

Applied, thanks to both of you.

- Carsten

On Feb 26, 2010, at 7:45 PM, David Maus wrote:

> Geralt wrote:
>> can nobody else reproduce my problem? btw. I forgot to mention that
>> I'm using Emacs 23.1.1 and Orgmode 6.21b
>
> I could reproduce it and attached is a fix.
>
> The problem was, that the function that queries the global id database
> did not take in account `org-id-locations' beeing set to nil (i.e.:
> global database disabled).
>
> HTH
> -- David
>
> --
> OpenPGP... 0x99ADB83B5A4478E6
> Jabber.... dmjena@jabber.org
> Email..... maus.david@gmail.com
> <org-fix-org-id-find-id- 
> file.patch>_______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten