From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Lundin <mdl@imapmail.org>
Subject: Re: [PATCH] org-bibtex.el --- convert between Org headings and
 bibtex entries
Date: Fri, 22 Apr 2011 20:03:52 -0400
Message-ID: <87r58tdeaf.fsf@fastmail.fm>
References: <87y6357q81.fsf@gmail.com> <87liz5aztx.fsf@fastmail.fm>
	<878vv22xgz.fsf_-_@gmail.com> <87r58uz3ux.fsf@fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:34208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lundin@fastmail.fm>) id 1QDQKJ-0003S0-Uh
	for emacs-orgmode@gnu.org; Fri, 22 Apr 2011 20:03:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lundin@fastmail.fm>) id 1QDQKJ-0005hy-5j
	for emacs-orgmode@gnu.org; Fri, 22 Apr 2011 20:03:55 -0400
Received: from out4.smtp.messagingengine.com ([66.111.4.28]:52095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lundin@fastmail.fm>) id 1QDQKI-0005hp-Td
	for emacs-orgmode@gnu.org; Fri, 22 Apr 2011 20:03:55 -0400
In-Reply-To: <87r58uz3ux.fsf@fastmail.fm> (Matt Lundin's message of "Fri, 22
	Apr 2011 11:45:58 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Matt Lundin <mdl@imapmail.org> writes:

> "Eric Schulte" <schulte.eric@gmail.com> writes:
>> As one possible solution to this name conflict, I've folded my
>> org-bibtex.el into the existing org-bibtex.el in the Org-mode core.  The
>> attached patch performs this integration adding the functionality in my
>> version of org-bibtex.el into the Org-mode core.
>>
>> Does this seem like an appropriate addition?
>
> +1 (or maybe +.75 -- see below)
>
> I think this could finally tempt me to move all my bibliographical data
> into org-mode files. (I've been keeping all my data in a central bibtex
> file and using reftex to generate links to citations.)

I've been testing the patch and have a few comments. 

1. The prompt for the completing-read on line 440 is missing a space. It
   shows "Type:" rather than "Type: ".

2. In addition, since the symbols in org-bibtex-types are keywords, the
   completions are in the form ":article", ":book", etc. Might I ask why
   everything is org-bibtex-type is a keyword? Could we use strings or
   plain symbols instead? (Note: I haven't read the code carefully
   enough to see if there is a reason.)

3. The tooltip/help pop-up for org-bibtex-create takes up half a frame.

Thanks,
Matt