Michael Strey writes: Hello Michael, > On Tue, Apr 09, 2013 at 09:31:40AM +0200, Michael Strey wrote: > > [...] > >> The problem is on the side of org-contacts. Org-contacts does not >> support links in its properties. > [...] > >> This shortcoming effects not only the phone links but email links as >> well. > > Attached is a patch to allow org links in org-contacts properties. > It allows entries like in the following example without effecting > org-contacts current functions. > > #+BEGIN_SRC org > * Surname, Name > :PROPERTIES: > :EMAIL: mailto:test2@test.de; [[mailto:name@test.de]] foo@bar.biz > :PHONE: [[tel:+49 351 4129535]], +491766626196 [[+49 (351) 41295-35]] > :END: > #+END_SRC > > Phone links of the form [[tel:+49 351 412 95-35][My phone number]] or > [[tel:+49 351 41295-35]] are expected. `-', `/', `(', `)' and > whitespace characters are allowed in telephone numbers. Thank you for your patch, though here are a few suggestions: - It looks like `chomp' does the same thing the `org-trim' (in `org.el') if so you should use it. - You should use `org-link-display-format' instead of `org-contacts-strip-link'. - You have done some unrelated changes (fix some typos, ...), could you provide a separated patches for them? Regarding `org-contacts-split-property', I haven't found anything about multiple values within a node property in `org-element' and the syntax description doesn't mention it, so you were right to roll your own. :) However, I think it would be better to store the separators in a variable (like `org-contacts-property-values-separator') and maybe even to use it by default instead of `split-string-default-separators' because we use it more and because it's easy to forget. > + (loop for email in (org-contacts-split-property email-list) ^^^^ > + for gravatar = (gravatar-retrieve-synchronously (org-contacts-strip-link email)) What do you think? Thanks again for your time! Regards, -- Daimrod/Greg