From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.
Date: Fri, 07 Jun 2013 14:35:43 +0200 [thread overview]
Message-ID: <87r4gew128.fsf@gmail.com> (raw)
In-Reply-To: <87txlbylja.fsf_-_@pank.eu> (rasmus@gmx.us's message of "Thu, 06 Jun 2013 23:30:33 +0200")
Hello,
Rasmus <rasmus@gmx.us> writes:
> Nicolas Goaziou <n.goaziou@gmail.com> writes:
> is the attached patch better?
It is, thank you. Here is another round of comments.
> + (replace-match (mapconcat 'identity
> + (if language
> + (cond ((member language options)
> + (delete "AUTO") options)
> + ((member "AUTO" options)
> + (dotimes (n (length options) options)
> + (if (equal "AUTO" (nth n options))
> + (setf (nth n options) language))))
> + (t (append options (list language))))
> + (delete "AUTO" options))
I suggest to use something like this instead:
(mapconcat (lambda (option) (if (equal "AUTO" option) language option))
(cond ((member language options) (delete "AUTO" options))
((member "AUTO" options) options)
(t (append options (list language)))))
> - nil nil header 1))))))
> + t nil header 1)))))
Why do you need to use a non-nil FIXEDCASE argument here?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-06-07 12:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:33 [PATCH][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language Rasmus
2013-06-01 5:31 ` Achim Gratz
2013-06-01 13:59 ` Rasmus
2013-06-01 14:07 ` Rasmus
2013-06-03 7:44 ` Sebastien Vauban
2013-06-03 13:47 ` Rasmus
2013-06-03 14:08 ` Sebastien Vauban
2013-06-03 15:10 ` Rasmus
2013-06-04 6:45 ` Sebastien Vauban
2013-06-04 9:25 ` [PATCH (new version)][ox-latex.el] " Rasmus
2013-06-05 13:35 ` Nicolas Goaziou
2013-06-06 7:46 ` Sebastien Vauban
2013-06-06 9:28 ` Rasmus
2013-06-06 9:36 ` Rasmus
2013-06-06 21:30 ` [PATCH (v3)][ox-latex.el] " Rasmus
2013-06-07 12:35 ` Nicolas Goaziou [this message]
2013-06-07 13:16 ` Rasmus
2013-06-07 13:25 ` Nicolas Goaziou
2013-06-07 15:26 ` Rasmus
2013-06-09 7:55 ` Nicolas Goaziou
2013-06-11 23:12 ` [PATCH (v5)][ox-latex.el] " Rasmus
2013-06-12 13:27 ` Nicolas Goaziou
2013-06-12 14:32 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4gew128.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).