From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Shu Subject: Re: [PATCH] [need test]Restruct `org-create-formula-image' function Date: Sun, 21 Jul 2013 06:20:38 +0800 Message-ID: <87r4esrhzd.fsf@gmail.com> References: <87zjthb8sa.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0fWB-0002FS-Jc for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 18:20:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0fWA-0006UL-NM for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 18:20:47 -0400 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:46634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0fWA-0006UF-Gl for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 18:20:46 -0400 Received: by mail-pa0-f52.google.com with SMTP id kq13so156825pab.11 for ; Sat, 20 Jul 2013 15:20:45 -0700 (PDT) Received: from smtp.gmail.com ([2001:c08:2600::713]) by mx.google.com with ESMTPSA id ys4sm27084483pbb.9.2013.07.20.15.20.42 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 20 Jul 2013 15:20:44 -0700 (PDT) In-Reply-To: <87zjthb8sa.fsf@gmail.com> (Nick Dokos's message of "Sat, 20 Jul 2013 10:33:41 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nick Dokos writes: > feng shu writes: > >> `org-create-formula-image-with-dvipng' and >> `org-create-formula-image-with-imagemagick' >> share a good deal of logic, so combine them to a function. >> >> > > I have wondered aloud in the past whether it is necessary to have two > methods for this. They are pretty much equivalent although the > imagemagick method is IMO slightly less brittle than the dvipng method. > So instead of spending time to tie them even more closely together, we > should investigate whether one of them should go. > > Maybe we can have a poll... imagemagick method is useful for xelatex users, but it compile a snippet more slower than dvipng method. We don't need remove one of them. we can do like this: 1. conbine tex:dvipng and tex:imagemagick to tex:image 2. remove `org-latex-create-formula-image-program' 3. defcustom `org-create-formula-image-processes' in my patch. 4. update document. It is very similar `org-latex-pdf-process' --