From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] Re: [BUG] org-cycle on hidden inline task makes also
 other inline tasks visible
Date: Tue, 29 Oct 2013 21:02:15 +0100
Message-ID: <87r4b3c0c8.fsf@gmail.com>
References: <87ioyftsdn.fsf@kafka.loc> <87a9hsc9f9.fsf@kafka.loc>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VbFUK-0000dc-Lt
	for emacs-orgmode@gnu.org; Tue, 29 Oct 2013 16:02:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VbFUE-0006bd-Ns
	for emacs-orgmode@gnu.org; Tue, 29 Oct 2013 16:02:04 -0400
Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:64196)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VbFUE-0006bR-B5
	for emacs-orgmode@gnu.org; Tue, 29 Oct 2013 16:01:58 -0400
Received: by mail-wg0-f52.google.com with SMTP id k14so380114wgh.19
	for <emacs-orgmode@gnu.org>; Tue, 29 Oct 2013 13:01:57 -0700 (PDT)
In-Reply-To: <87a9hsc9f9.fsf@kafka.loc> ("Jonas
	\=\?utf-8\?Q\?H\=C3\=B6rsch\=22's\?\= message of "Tue, 29
	Oct 2013 17:46:02 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jonas =?utf-8?Q?H=C3=B6rsch?= <coroa@online.de>
Cc: emacs-orgmode@gnu.org

Hello,

coroa@online.de (Jonas H=C3=B6rsch) writes:

> ok, this has been bothering me long enough. the attached patch fixes the
> issue [1] for me.

Thank you for your patch.

> From 3073cb181f607a0cc65031fe68e86cf73347e152 Mon Sep 17 00:00:00 2001
> From: Jonas Hoersch <coroa@online.de>
> Date: Tue, 29 Oct 2013 17:07:49 +0100
> Subject: [PATCH] org-inlinetask: [FIX] correct inlinetask cycling

You need to detail which function is modified and how. E.g.:

 * lisp/org-inlinetask.el (org-inlinetask-toggle-visibility): Don't use
   `org-show-entry' as it cannot fold an inlinetask properly.

> org-show-entry can't be used to expand a folded inlinetask, as it relies
> on org-outline-regexp to find the end of the entry, which has been
> altered to exclude inline-tasks by org-cycle.
>
> instead show the inline task directly using the bounds already computed
> by org-inlinetask-toggle-visibility.

Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
the end of the message.


Regards,

--=20
Nicolas Goaziou