From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: links to attachments don't export anymore
Date: Fri, 15 Nov 2013 18:35:31 +0100
Message-ID: <87r4ahk1p8.fsf@gmail.com>
References: <87r4alczdk.fsf@gmail.com> <ywodsiuzrqjy@de.bosch.com>
	<87a9h5li6m.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48848)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VhNIe-0004m4-Cl
	for Emacs-orgmode@gnu.org; Fri, 15 Nov 2013 12:35:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VhNIY-0003x4-J1
	for Emacs-orgmode@gnu.org; Fri, 15 Nov 2013 12:35:20 -0500
Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:41603)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1VhNIY-0003wX-Cs
	for Emacs-orgmode@gnu.org; Fri, 15 Nov 2013 12:35:14 -0500
Received: by mail-ee0-f44.google.com with SMTP id d51so1229365eek.31
	for <Emacs-orgmode@gnu.org>; Fri, 15 Nov 2013 09:35:13 -0800 (PST)
In-Reply-To: <87a9h5li6m.fsf@gmail.com> (Nicolas Goaziou's message of "Fri, 15
	Nov 2013 17:54:09 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Thomas Holst <thomas.holst@de.bosch.com>
Cc: Myles English <mylesenglish@gmail.com>, Emacs-orgmode <Emacs-orgmode@gnu.org>, Carsten Domink <carsten.dominik@gmail.com>

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
>
> Thomas Holst <thomas.holst@de.bosch.com> writes:
>
>> =C2=B7 Myles English <mylesenglish@gmail.com> wrote:
>>
>> [ ... snip ... ]
>>> It was possible to insert a link to an attachment like this:
>>>
>>> [[att:FigureA.jpg]]
>>>
>>> and clicking on it would show the file (still works), and it would show
>>> up in the exported document (no longer happens).
>> [ ... snip ... ]
>>
>> since I like this feature I'd like to give this thread a bump. With git
>> bisecting I found that commit:
>>
>> 026b99ecb86e08f4fdc7b45ee2bfa1d4c84a37f6 is the first bad commit
>> commit 026b99ecb86e08f4fdc7b45ee2bfa1d4c84a37f6
>> Author: Nicolas Goaziou <n.goaziou@gmail.com>
>> Date:   Fri Aug 30 13:29:51 2013 +0200
>
> Since I have been proven guilty, let me add it to my TODO list.

Actually, this could solved by widening the buffer before expanding the
link in `org-element-link-parser'.

Though, I'm surprised that neither `org-id-get', `org-entry-get' nor, at
the most basic level, `org-entry-properties' remove narrowing before
computing their return value.

Is there any reason for this? AFAICT, it would be better to wrap them
with a `org-with-wide-buffer' macro.

Cc'ing Carsten before patching blindly.


Regards,

--=20
Nicolas Goaziou