From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance Date: Mon, 17 Mar 2014 20:20:02 +0100 Message-ID: <87r460pr8d.fsf@Rainer.invalid> References: <87bnx9qbcq.fsf@bzg.ath.cx> <87vbvcptqt.fsf@Rainer.invalid> <87ob14d4o7.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPd5H-0001Zt-A8 for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:20:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPd58-0006Sf-AM for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:20:27 -0400 Received: from plane.gmane.org ([80.91.229.3]:53605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPd58-0006SS-3q for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:20:18 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WPd52-0003A5-GB for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 20:20:12 +0100 Received: from pd9eb1a5e.dip0.t-ipconnect.de ([217.235.26.94]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Mar 2014 20:20:12 +0100 Received: from Stromeko by pd9eb1a5e.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Mar 2014 20:20:12 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien writes: > Can you tell a bit more about what's wrong with the test? There is nothing wrong with those tests. > If the patch is good and the tests are outdated, I'd rather > fix the tests than revert the patch to re-revert it again. No, the patch is bad, otherwise it wouldn't break the tests. It may well be that there'd be more tests needed to catch that bug the patch supposedly fixes. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack V1.04R1: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada