From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [bug] [babel] babel corrupts undo history Date: Fri, 21 Mar 2014 23:07:49 +0100 Message-ID: <87r45vkxxm.fsf@bzg.ath.cx> References: <87d2oxanct.fsf@gmail.com> <87hae9ajz2.fsf@gmail.com> <87bo4h8x63.fsf@gmail.com> <877gcx19zc.fsf@gmail.com> <871u3517no.fsf@gmail.com> <87lhw7cjws.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR7bo-00015k-PK for emacs-orgmode@gnu.org; Fri, 21 Mar 2014 18:08:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WR7bi-0003Mc-PD for emacs-orgmode@gnu.org; Fri, 21 Mar 2014 18:08:12 -0400 Received: from rs249.mailgun.us ([209.61.151.249]:59842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR7bi-0003MR-Jz for emacs-orgmode@gnu.org; Fri, 21 Mar 2014 18:08:06 -0400 In-Reply-To: (Samuel Wales's message of "Fri, 21 Mar 2014 14:34:51 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Samuel Wales Cc: emacs-orgmode@gnu.org, Eric Schulte Hi Samuel, Samuel Wales writes: > typical example of last one: > > === > * bastien > #+begin_src org > bastien > ^bastien > #+end_src > * bastien > === > > put point at ^, fill-paragraph, undo. with undo-tree, at least, the > buffer will be corrupted. Not for me. This has surely to do with undo-tree. > one thing org sometimes does is try to set buffer-undo-list. it's > really for speed imo. i can't think of any reason why org really > needs it. perhaps i am mistaken and there is a really good reason for > such things, but i suspect it has caused a lot of bugs. I can safely say this is *never* for speeding things up, it's for preserving the undo list state. > in the case of c-c ', i would prefer having the indentation adding > show up as an undo entry [or whatever would happen if we ripped out > the undo-related setting]. Unless I misunderstand, the addition of indentation is not manually done, so it should not be part of the undo list. > even when there is not a bug per se, when you edit a source block, > there is a gap in the undo record. like nixon's tape gap during > watergate, it raises questions. :/ :) > to me, undo is a low-level feature that should never be buggy or > surprising. if it is, then anything that causes those should be > ripped out, even if it means losing a fancy undo-related feature. Fully agreed. Let's raise bugs in this area when you have time and when the bug can be isolated from other third-part package. Maybe that's me not being able to reproduce the ones you mention, but other people can chime in too, if the bug is real. Thanks! -- Bastien