From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: [RFC] Rewrite indentation functions Date: Sun, 04 May 2014 11:30:29 +0800 Message-ID: <87r44ab4q2.fsf@ericabrahamsen.net> References: <87oazjnf55.fsf@gmail.com> <87d2fwhh95.fsf@ericabrahamsen.net> <87fvksoctz.fsf@gmail.com> <87oazffgne.fsf@ericabrahamsen.net> <8738grw8nn.fsf@ericabrahamsen.net> <87tx97ozhr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgn7z-0005pY-OD for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:30:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wgn7t-00056D-J7 for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:30:11 -0400 Received: from plane.gmane.org ([80.91.229.3]:33344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgn7t-00053Z-CD for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:30:05 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Wgn7r-0006sI-OQ for emacs-orgmode@gnu.org; Sun, 04 May 2014 05:30:03 +0200 Received: from 111.197.167.19 ([111.197.167.19]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 04 May 2014 05:30:03 +0200 Received: from eric by 111.197.167.19 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 04 May 2014 05:30:03 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >>> Right now I'm seeing breakage with `org-set-property' -- this only >>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >>> property with that command, value of "asdfadsf", gives me this: >>> >>> * Test Heading >>> :PROPERTIES: >>> >>> :EXPORT_AUTHOR: asdfasdfnil nil >>> >>> Extra blank nil, spurious "nils", and no :END: > > [...] > >> Specifically, in this section of `org-indent-line': >> >> (when (eq type 'node-property) >> (let ((column (current-column))) >> (save-excursion >> (beginning-of-line) >> (looking-at org-property-re)) >> (replace-match (concat (match-string 4) >> (format org-property-format >> (match-string 1) >> (match-string 3))) >> t t) >> (org-move-to-column column))) >> >> Those match-string calls toward the end both return "nil", and the >> "nil"s get inserted directly into the buffer. I tried this with a >> minimal setup (load-paths only, and a blank Org file) and could >> reproduce. > > Indeed. I attach a replacement for both patch 1 and 2. One other thing: I was going to poke around with code block indentation and see if I could break it, but I can't get the third patch to apply cleanly any more. I don't know if it's because I rebased this testing branch against an update master, or if your changes to the first two patches mean the third needs to be edited accordingly... It fails at org.el:22368, which is this line inside `org-indent-line': (skip-chars-backward " \r\t\n") Perhaps we need a new version of patch 3? Eric