From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Patch for testing `org-open-at-point' Date: Sun, 01 Jun 2014 23:14:04 +0200 Message-ID: <87r438uycj.fsf@bzg.ath.cx> References: <878urc0zmw.fsf@bzg.ath.cx> <874n1ryeq1.fsf@bzg.ath.cx> <87y4xgxu74.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrD55-0008Ak-Op for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 17:14:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrD50-0002ce-Jx for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 17:14:15 -0400 Received: from mail-s76.mailgun.info ([184.173.153.204]:49007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrD50-0002bl-Df for emacs-orgmode@gnu.org; Sun, 01 Jun 2014 17:14:10 -0400 In-Reply-To: <87y4xgxu74.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 01 Jun 2014 22:15:27 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > York Zhao writes: >> Thank you very much for implementing this. Really appreciated. So do you think >> it is a good idea to add my test (the patch) now for testing this? > > Shouldn't the test check that the desired target is actually > reached? That would be too complicated. Checking that `org-open-at-point' does not throw an error is enough IMO. -- Bastien