From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps Date: Wed, 25 Nov 2015 15:52:52 +0100 Message-ID: <87r3je8723.fsf@nicolasgoaziou.fr> References: <87ziy28ccw.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bPY-0007ov-Gx for emacs-orgmode@gnu.org; Wed, 25 Nov 2015 09:51:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1bPV-0007Av-7O for emacs-orgmode@gnu.org; Wed, 25 Nov 2015 09:51:08 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bPV-0007An-1L for emacs-orgmode@gnu.org; Wed, 25 Nov 2015 09:51:05 -0500 In-Reply-To: ("Gustav \=\?utf-8\?Q\?Wikstr\=C3\=B6m\=22's\?\= message of "Wed, 25 Nov 2015 14:44:10 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= Cc: "sgeorgii ." , "emacs-orgmode@gnu.org" Gustav Wikstr=C3=B6m writes: > Hmm, since the error was thrown when trying to look at indexes outside > of the string in (substring ... ), I don't see how isregexp can be > left as is. We have to make sure the substring-code is not evaluated > if the tag is empty. What am I missing? Nothing, I was clear as mud. (cond ((string=3D "" tag) (setq f1 '(not tags))) ((and (equal "{" ...) (equal "}"...)) ...) (t ...)) Or even ((and (string-prefix-p "{" ...) (string-suffix-p "}" ...))) on master. Regards,