From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: [PATCH] Re: links-9.0 v3 Date: Fri, 05 Aug 2016 20:14:10 -0500 Message-ID: <87r3a28zrx.fsf@fastmail.fm> References: <87oa6afmeu.fsf@saiph.selenimh> <87k2gxg8qm.fsf@saiph.selenimh> <8737nlfqdv.fsf@saiph.selenimh> <87y45bvm12.fsf@saiph.selenimh> <8737n7go9k.fsf@saiph.selenimh> <87lh0zexsy.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVqC7-0001uz-LQ for emacs-orgmode@gnu.org; Fri, 05 Aug 2016 21:14:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVqC3-0002bz-Dn for emacs-orgmode@gnu.org; Fri, 05 Aug 2016 21:14:30 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVqC0-0002bh-Tf for emacs-orgmode@gnu.org; Fri, 05 Aug 2016 21:14:27 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: John Kitchin Cc: "emacs-orgmode@gnu.org" , Nicolas Goaziou --=-=-= Content-Type: text/plain Thanks, John, for improving link functionality in org-mode! I just discovered that this change breaks the contrib files that use org-store-link-functions and org-add-link-type. I'm not familiar enough with the details of org-link-set-parameters to fix all of the contrib files, but I am including a simple patch to update a contrib file that I use regularly: org-eww.el. Thanks, Matt --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Update-org-eww-to-use-new-link-api.patch >From d473260956493dafd1e37c5f3680813fbf63434e Mon Sep 17 00:00:00 2001 From: Matt Lundin Date: Fri, 5 Aug 2016 20:07:40 -0500 Subject: [PATCH] Update org-eww to use new link api * contrib/lisp/org-eww.el: org-store-link-functions: Remove obsolete hook. (org-link-set-parameters) Use new api for links. --- contrib/lisp/org-eww.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/lisp/org-eww.el b/contrib/lisp/org-eww.el index 11ccb68..a443255 100644 --- a/contrib/lisp/org-eww.el +++ b/contrib/lisp/org-eww.el @@ -48,7 +48,7 @@ ;; Store Org-link in eww-mode buffer -(add-hook 'org-store-link-functions 'org-eww-store-link) +(org-link-set-parameters "eww" :store #'org-eww-store-link) (defun org-eww-store-link () "Store a link to the url of a eww buffer." (when (eq major-mode 'eww-mode) -- 2.9.2 --=-=-=--