org-open-link-from-string truncates file path at spaces

org-open-link-from-string truncates file path at spaces

[Joon Ro]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi,

With current org version (Org mode version 9.1.8 (9.1.8-elpaplus @ c:/Users/joon/.emacs.d/elpa/org-plus-contrib-20171228/)), org-open-link-from-string does not work with a path string if it includes a space. For example,

(org-open-link-from-string "file:test test.hmtl")

yields

user-error: No such file: c:/Users/joon/test

Best Regards,
Joon

[-- Attachment #2: Type: text/html, Size: 2533 bytes --]

Re: org-open-link-from-string truncates file path at spaces

[Bastien]

Hi Joon,

Joon Ro <joon.ro@outlook.com> writes:

> With current org version (Org mode version 9.1.8 (9.1.8-elpaplus @ c:
> /Users/joon/.emacs.d/elpa/org-plus-contrib-20171228/)), 
> org-open-link-from-string does not work with a path string if it
> includes a space. For example,
>
> (org-open-link-from-string "file:test test.hmtl")
>
> yields
>
> user-error: No such file: c:/Users/joon/test

Fixed in maint, thanks.

-- 
 Bastien

Re: org-open-link-from-string truncates file path at spaces

[Nicolas Goaziou]

Hello,

Bastien <bzg@gnu.org> writes:

> Hi Joon,
>
> Joon Ro <joon.ro@outlook.com> writes:
>
>> With current org version (Org mode version 9.1.8 (9.1.8-elpaplus @ c:
>> /Users/joon/.emacs.d/elpa/org-plus-contrib-20171228/)), 
>> org-open-link-from-string does not work with a path string if it
>> includes a space. For example,
>>
>> (org-open-link-from-string "file:test test.hmtl")
>>
>> yields
>>
>> user-error: No such file: c:/Users/joon/test
>
> Fixed in maint, thanks.

I reverted this fix because it introduces an error when trying to edit
a file in an INCLUDE keyword.

The initial report is wrong anyway, because "file:test test.hmtl" is not
a valid link syntax, i.e., plain links cannot contain spaces. It should
be:

    (org-open-link-from-string "[[file:test test.hmtl]]")

IMO, there is nothing to fix in the first place.

Regards,

-- 
Nicolas Goaziou

Re: org-open-link-from-string truncates file path at spaces

[Bastien]

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> The initial report is wrong anyway, because "file:test test.hmtl" is not
> a valid link syntax, i.e., plain links cannot contain spaces. It should
> be:
>
>     (org-open-link-from-string "[[file:test test.hmtl]]")
>
> IMO, there is nothing to fix in the first place.

Indeed, sorry for the wrong fix here and thanks for the revert.

-- 
 Bastien

Re: org-open-link-from-string truncates file path at spaces

[Joon Ro]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi -

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> The initial report is wrong anyway, because "file:test test.hmtl" is not
> a valid link syntax, i.e., plain links cannot contain spaces. It should
> be:
>
>     (org-open-link-from-string "[[file:test test.hmtl]]")
>
> IMO, there is nothing to fix in the first place.

Thanks - (org-open-link-from-string "[[file:test test.html]]") works perfectly.

Best,
Joon


[-- Attachment #2: Type: text/html, Size: 2123 bytes --]