From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: Bug or not a bug? dot expansion in ob-shell
Date: Wed, 19 Feb 2020 13:27:26 +0100
Message-ID: <87r1yqep8x.fsf@gnu.org>
References: <CA+A2iZaziAfMeGpBqL6qGrzrWEVvLvC0DUw++T4gCF3NGuW-DQ@mail.gmail.com>
 <87eeur3p1p.fsf@ucl.ac.uk> <87a75eap8k.fsf@gnu.org>
 <87y2sy3kkl.fsf@ucl.ac.uk> <87r1yq4xiz.fsf@gnu.org>
 <875zg2kcy0.fsf@ucl.ac.uk> <874kvmsrpw.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:53162)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1j4ORv-0005D3-Kb
 for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 07:27:36 -0500
In-Reply-To: <874kvmsrpw.fsf@gnu.org> (Bastien's message of "Wed, 19 Feb 2020
 13:10:19 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: "Fraga, Eric" <e.fraga@ucl.ac.uk>
Cc: Vladimir Nikishkin <lockywolf@gmail.com>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Bastien <bzg@gnu.org> writes:

> Then we need to fix ob-shell.el to return the exit code of the last
> command when :results is not set or explicitely set to "value".  Is
> this something you want to look at?
>
> Maybe by adding a "echo $?" instruction at the end of shell blocks
> or by wrapping the code into something that returns the result?
>
> I think it will come as a surprise for many users, since the natural
> expectation seems to get the "output", disregarding bash notion of a
> "return value".

Maybe ob-shell.sh could have an option ob-shell-value-is-exit-status
set to nil by default to stick with the current behavior, but letting
users get the exit status as the value if they want to.

WDYT?

-- 
 Bastien