From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: attachment: link type export to HTML invalid attach dir
Date: Thu, 20 Feb 2020 11:20:14 +0100
Message-ID: <87r1yp36ht.fsf@gnu.org>
References: <PR1PR02MB47323A141AE248937F2FA7D4DAFB0@PR1PR02MB4732.eurprd02.prod.outlook.com>
 <HE1PR02MB3033A78363C6CB71D1AFA929DA300@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87pnfhrob4.fsf@nicolasgoaziou.fr>
 <HE1PR02MB30339DA3A17FBE14F0F924AFDA300@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <871rrvrw0b.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033EB926B8B582D176EB8E5DA330@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87muairkam.fsf@nicolasgoaziou.fr>
 <HE1PR02MB303324C053A518999533F379DA090@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87y2th0yc7.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033654FFD2F806D0B5EC83DDA1D0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <878sle1ng9.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033668D1D2CD40DB2C7E932DA1F0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <875zgausnb.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033AA077F9896011A161813DA1A0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87o8u2tbhg.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033FD69FC2C3EC94BA5ECD8DA1A0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87zhdlctsm.fsf@bzg.fr> <87a75lt7nc.fsf@nicolasgoaziou.fr>
 <87d0ag29kk.fsf@gnu.org> <87h7zrradl.fsf@nicolasgoaziou.fr>
 <871rqphaxo.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:59649)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1j4iwN-0000yY-LZ
 for emacs-orgmode@gnu.org; Thu, 20 Feb 2020 05:20:20 -0500
In-Reply-To: <871rqphaxo.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
 "Thu, 20 Feb 2020 10:20:35 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Gustav =?utf-8?Q?Wikstr=C3=B6m?= <gustav@whil.se>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> This second patch removes most of the "attachment" leakage in the code
> base (mainly "org-element.el" and "ox-*.el"). The features should be the
> same as before. Let me know if there's anything wrong.

Thanks a lot -- feel free to apply it when you think it's okay.

Also, perhaps can you or Gustav suggest a way to test the new feature
so that we can test this new code?

> The only thing left is to refactor the ability to display "attachment"
> links as inline images. For now, this is hard-coded in "org.el", but
> this should not be the case.
>
> As a third phase, I suggest to add a new parameter in
> `org-link-parameters', for example :inlineable. This parameter would be
> either a boolean, or a function transforming the path. For example,
> "file" links should set it to t and "attachment" links to
> `org-attach-expand'. Then `org-display-inline-images' should collect
> link types with this flag, apply the transformation, and display images
> accordingly.

Do you want to do this for 9.4 or can it be done later on?

Thanks,

-- 
 Bastien