From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wF4NJNvWyl6EAwAA0tVLHw (envelope-from ) for ; Sun, 24 May 2020 20:19:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UOgfINvWyl6ScAAAB5/wlQ (envelope-from ) for ; Sun, 24 May 2020 20:19:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DDB8B9400C3 for ; Sun, 24 May 2020 20:19:38 +0000 (UTC) Received: from localhost ([::1]:49668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcx5t-00079n-TX for larch@yhetil.org; Sun, 24 May 2020 16:19:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcx5X-00079e-KZ for emacs-orgmode@gnu.org; Sun, 24 May 2020 16:19:15 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:50619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcx5V-0007Lq-Fk; Sun, 24 May 2020 16:19:14 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6B2A25F236; Sun, 24 May 2020 16:19:11 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=Zho2rZ264VWCd2FgYX+gvkI45wA=; b=xN2jsj IVZ64VNqR+hut95wpDz4yKvchIWYS8srxrh/ckwmGKSFGA+izK4rnoVHI0Upgug0 gzT+FyyZjuXmdFPrbOVj5M+IyaHVeqML0loYUXhvHqUVYDXTKgsKIggRMPy9KEEM WpQ68vpwFrk0aQoiZkrAbDqcUWSSzYQ7JDik8= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 636135F235; Sun, 24 May 2020 16:19:11 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=fnQJpRb4WR3WxEQPzMSs8oFGarHvMckeC4Sq75uAPw8=; b=X9ExPGQZMzwTyw/4q/dQ48P5RM1bSABZSnWU9go9bEUpsGzcl3PTgvjkV0YTJqM4U1IX67yUe0/nkV1OZuc0FA3yoisXa0vovLVwfqvTxJUBBedZ0nQOo7ASB0yF2NUW1WqLkQE0C2caOttv1iOxPqvGfF3iN50FCfgf3mLGkZU= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D79565F234; Sun, 24 May 2020 16:19:10 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Kevin Foley Subject: Re: [PATCH] Fix `org-babel-detangle' handling of false positives In-Reply-To: References: <8736buek6n.fsf@gnu.org> <87h7zzdkqo.fsf@gnu.org> <87y2pk7zhn.fsf@gnu.org> <87wo51moo1.fsf@gnu.org> <87wo515mu6.fsf@kyleam.com> Date: Sun, 24 May 2020 20:19:10 +0000 Message-ID: <87r1v9rsqp.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D41964C8-9DFB-11EA-850F-D1361DBA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/24 16:19:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=xN2jsj I; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=X9ExPGQZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: x67tuMf+Yekl Kevin Foley writes: > Kyle Meyer writes: > >> Kevin, could you look into updating the test to avoid changing the repo >> state? > > Sorry about that. Do you have any suggestions on how to avoid changing > the state or any examples of similar tests? > > I tried the following to replace the file with it's original contents > but it doesn't seem to be working as I intend. I also worry it's a > convoluted approach and there may be a simpler way. Thanks for taking a look. The dirty working tree state happens when running all the ob-tangle tests but not when running just the test you added [*]. That makes me think the core issue is that the change from your test stays around to be save by another test. So I suspect you can avoid the dirty state by just wrapping the test in unwind-protect, making sure to kill the Org buffer before detangle-false-positive exits. [*] Specifically, running make BTEST_RE='ob-tangle' test-dirty versus make BTEST_RE='detangle' test-dirty