emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Vladimir Nikishkin <lockywolf@gmail.com>,
	emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Bug: why does org-goto call org-latex-preview?
Date: Wed, 27 May 2020 04:20:43 +0000	[thread overview]
Message-ID: <87r1v6vwis.fsf@kyleam.com> (raw)
In-Reply-To: <87mu5u5962.fsf@localhost>

Ihor Radchenko writes:

>> It looks like an oversight to me.  I think
>> org-startup-with-latex-preview should be let-bound to nil around
>> org-goto-location's call to org-mode.  Likewise, I'd say that
>> org-startup-with-inline-images and org-startup-shrink-all-tables should
>> be let-bound to nil.
>
> Is there even a need to call the whole (org-mode). The new buffer is
> an indirect buffer. It should already have org-mode activated (at least,
> we can check for it and not call (org-mode) unnecessarily). If we just
> want to reset initial visibility, (org-overview) is already doing the
> job of (org-set-startup-visibility) from (org-mode).

Hmm, thanks for taking a step back.  It does seem like the org-mode call
should be unnecessary. (I haven't tried yet.)  I wonder whether calling
org-mode could be a leftover from all the way back in 70b6cc5da (Release
5.10a, 2008-01-31), where there was a switch from using a normal buffer
to an indirect one.


  reply	other threads:[~2020-05-27  4:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27  2:59 Bug: why does org-goto call org-latex-preview? Vladimir Nikishkin
2020-05-27  3:45 ` Kyle Meyer
2020-05-27  3:49   ` Ihor Radchenko
2020-05-27  4:20     ` Kyle Meyer [this message]
2020-05-28  4:26       ` [PATCH] goto: Avoid invoking org-mode for outline navigation Kyle Meyer
2020-09-05  7:42         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1v6vwis.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=lockywolf@gmail.com \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).