From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wJ4CK4bv/17zLQAA0tVLHw (envelope-from ) for ; Sat, 04 Jul 2020 02:55:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kP3NJobv/14haQAAB5/wlQ (envelope-from ) for ; Sat, 04 Jul 2020 02:55:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 001F1940630 for ; Sat, 4 Jul 2020 02:55:01 +0000 (UTC) Received: from localhost ([::1]:32898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrYKS-0007mu-S4 for larch@yhetil.org; Fri, 03 Jul 2020 22:55:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrYJs-0007km-CC for emacs-orgmode@gnu.org; Fri, 03 Jul 2020 22:54:24 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:41175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jrYJq-0000t3-BZ for emacs-orgmode@gnu.org; Fri, 03 Jul 2020 22:54:24 -0400 Received: by mail-pf1-x434.google.com with SMTP id q17so14634743pfu.8 for ; Fri, 03 Jul 2020 19:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=5GAc8RyZ2M9itK3bbloBcpkI3k9g3eq0XUj1cC+th2k=; b=oi3PbgkGgRsX9osYOxW80JgmDS4AOQkNlIMKbePTK6C5tx2sUC+qb2ia21uflipsCx ISshUy+bGp4HF3vI9FXmCdzbQ2Cd/jhtsuzVqb3wxNbBd0dK/v/IDWyM+99NPBTxBWn3 /c8OkW/43oFADM/tcEBVKxl44lCdw6Xiux9oAlCurA43wZ5DEM7NkhcLmA2nMtvk//Hi 3rx5ZzKqt5AIzNm+FfcGsoszM0keeymmpAxI9bg8jtvU/pfrLOAaeWwpzXYyZnIsLE74 KseyEttbxGiMKGHRxhBrbW86idCIRBJ/FItPxMmMGMvVIngH0jQoaNnqiOXkwA1YjgDf BR3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=5GAc8RyZ2M9itK3bbloBcpkI3k9g3eq0XUj1cC+th2k=; b=bQh/SnFGpzhe3UjYonQdUkqKsFCZ+QBZQD7dC8w+sG2O89wLKFtoq78FX+daPQXbN5 i8BEEEq2Ke2t45eRh9OX2LQqiyRphD2j/9N9VigqbWG9Ls23yh34Yj9T4Zi+rTkfFai9 0TnuJNU8pBTZ1O5GT77MsHt2uk6sVTOfVQYACuQkJS/laNC4f4Gq5ZjYypfi6n7Qcjpj wjZSzYaIMGn+nfQRU8Xwbqoyrfnlfji+qwZ4NBgeEHjDI6vqJVG9ZiGsW1fk75XqXevf KDaysWcILq4gPixkuhb0pB91Z0E880UWAgHU9JLEXCF8x3KUMzKcX6NrNgTcWLk3HGOA uzEg== X-Gm-Message-State: AOAM533yEFRNSCTnZ2xdZq8CrXl/chZbFA9nHPUVt3erv2eRBLQJVr3t /Ro+4ejjfT++ZTTm+SuUPIo= X-Google-Smtp-Source: ABdhPJzJeugQ7j2ZDowvzd2vOXZmqlke8BTrIrmD/tGsL8QLJSnqXij+Rp9l0MMuFYCHTWC39NbTHA== X-Received: by 2002:a63:125a:: with SMTP id 26mr32313310pgs.340.1593831260305; Fri, 03 Jul 2020 19:54:20 -0700 (PDT) Received: from localhost ([104.151.6.52]) by smtp.gmail.com with ESMTPSA id 21sm12998868pfv.43.2020.07.03.19.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 19:54:19 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec , emacs-orgmode@gnu.org Subject: Re: [9.4] LOGBOOK visibility In-Reply-To: <87pn9cihul.fsf@gmail.com> References: <87eepuz0bj.fsf@gmail.com> <87wo3kk8x1.fsf@gmail.com> <87pn9cihul.fsf@gmail.com> Date: Sat, 04 Jul 2020 10:53:56 +0800 Message-ID: <87r1ts3s8r.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=yantar92@gmail.com; helo=mail-pf1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=oi3PbgkG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: C3TCUcapg8CW > I haven't reached the bottom of this rabbit hole yet. Since I think > I've spent all the time I had to spend in this issue for the day, here's > where I'm at. There used to be several types of overlays for headline folding, drawer folding, and block folding. One of the recent commits made all the overlays use headline type. As a result all the overlays are merged into a single overlay upon folding. This was done to reduce the total number of overlays present in an org buffer, which degrades Emacs performance on huge org files (see the discussion in [1]).=20 What you observe is a consequence of that change. Now, all the drawer overlays are destroyed when you fold a heading. Isearch would only see a single huge overlay and unfold it alltogether. I am currently working on a patch to rewrite the whole folding system. Your issue should disappear once it is applied. Meanwhile, you may, for example, advice org-fold--isearch-filter-predicate to re-fold drawers during isearch.=20 Best, Ihor [1] https://www.mail-archive.com/emacs-orgmode@gnu.org/msg127740.html K=C3=A9vin Le Gouguec writes: > I haven't reached the bottom of this rabbit hole yet. Since I think > I've spent all the time I had to spend in this issue for the day, here's > where I'm at. > > If I open my example file[1] with Org 9.3 and master (86fada6b5), and > compare the overlays covering the hidden part of the first LOGBOOK > drawer, like so: > > #+begin_src sh > #!/bin/bash > > set -eu > > point=3D67 > > orgs=3D( > "${path_to_org_9_3}" > "${path_to_org_master}" > ) > > for o in "${orgs[@]}" > do > emacs -Q -batch \ > -L "${o}"/lisp \ > -eval "(find-file \"logbooks.org\")" \ > -eval "(message org-version)" \ > -eval "(dolist (o (overlays-at ${point})) > (message \"from %s to %s\" (overlay-start o) (overlay-= end o)) > (message \"%s\" (overlay-properties o)))" > echo > done > #+end_src > > Here is what I get: > >> 9.3 >> from 32 to 2015 >> (evaporate t invisible outline isearch-open-invisible #[lambda gibberish= involving (org-show-context 'isearch)]) >> from 67 to 262 >> (isearch-open-invisible delete-overlay invisible org-hide-drawer evapora= te t) >>=20 >> 9.3.7 >> from 32 to 2015 >> (isearch-open-invisible delete-overlay invisible outline evaporate t) > > - The LOGBOOK overlay (from 67 to 262) vanished. > > - The isearch-open-invisible property of the "project 1" overlay (from > 32 to 2015) changed from a lambda[2] to just delete-overlay. > > > Again, not sure this shows there's an issue; for all I know Org 9.4 just > works differently and nothing's wrong there. I hope someone can chime > in and take it up from here; otherwise I'll resume my investigations > sometime later. > > > [1] https://orgmode.org/list/87eepuz0bj.fsf@gmail.com/2-logbooks.org > > [2] Which I guess is the value of > outline-isearch-open-invisible-function, set locally by org-mode in > the major mode function? > --=20 Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong U= niversity, Xi'an, China Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg