From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uNNxNHxjVF+qeAAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 04:20:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mC1uMHxjVF+NZQAAB5/wlQ (envelope-from ) for ; Sun, 06 Sep 2020 04:20:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 36BDA9404C4 for ; Sun, 6 Sep 2020 04:20:12 +0000 (UTC) Received: from localhost ([::1]:56894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEm9x-0003Ew-6o for larch@yhetil.org; Sun, 06 Sep 2020 00:20:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEm9b-0003Ep-VP for emacs-orgmode@gnu.org; Sun, 06 Sep 2020 00:19:47 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:62496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEm9Y-0006uw-V5 for emacs-orgmode@gnu.org; Sun, 06 Sep 2020 00:19:46 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 494EBFEB19; Sun, 6 Sep 2020 00:19:41 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=vLKHkBCJ8JnbYN1BhwqJsGOWw7M=; b=wl7FJZ Aj6ayvOW59qPgoldibLByRZ6RZAtQ+l6XgPLDak5B15n9wHCXVIG79N1gpECN1vq BweBachNMJ8Ap4M+07bbFp8yJGkIiQG+8OJ6pV//rxaef9BxZATBnt9A6ZJWAnZV SFEEfUlACC36BaS3ppbhO/UX7dFieTQoDPkOg= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 40BD3FEB18; Sun, 6 Sep 2020 00:19:41 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=itwA7VGwkQf8sXh7SK176solHqylsi3z29U7eVKKHiA=; b=Jm83nSE9YBrkp3nr+OV3/BQjcBTnU1JoA1S3Q8d+yQ73C+PXyBib+t/CPyB46lOXxNyuzUnGadehTwQ6FR4Lyq1LEtr0UqEDGyV+Nh9MHQgfO3c5D1hZXu7k3AXApL8BWB0QS+E8estvbMV169Kl7F3jL0uu3zyM3cKl4Q6a1cw= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id B858CFEB17; Sun, 6 Sep 2020 00:19:38 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Huszaghmatt Subject: Re: [PATCH] Omit file description when :file-desc has nil value In-Reply-To: References: Date: Sun, 06 Sep 2020 00:19:36 -0400 Message-ID: <87r1rf35bb.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 2DCEC00A-EFF8-11EA-90F6-843F439F7C89-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/06 00:19:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emacs-Orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=wl7FJZ A; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=Jm83nSE9; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: Zgb8sjtkk08m Hi Matt, It looks like this message got detached from the original thread [*] and ended up a bit misformatted (at least for plain-text readers). This seems to be the message you accidentally sent to me off-list, so I will copy my reply here as well. [*] https://orgmode.org/list/87tuwef76g.fsf@kyleam.com Matt Huszagh writes: > Thanks for the reply, Kyle, and thanks for pointing me to that thread. I > understand that this would break existing functionality, but I think my > solution makes more sense. For one, I think that the current > implementation is a bit confusing. More importantly though, it makes it > impossible to both provide a default value for :file-desc and omit it in > some cases. The benefit (as mentioned in that thread) is that in those > select cases, the same argument would not need to be provided twice. I > think the cost of the current functionality outweighs the benefit. What > are your thoughts? I also don't find the current behavior particularly intuitive. (I'm also not really a babel user, so my opinion probably shouldn't count for much.) If we were adding it today, I think what you describe would be better, but, as you mention, breakage also now also weighs against making a change here. In any case, I'd suggest raising the discussion on the list after the 9.4 release. >> Right, to reflect the current behavior established as a result of the >> above thread, I think that should be reworded to distinguish between an >> absent :file-desc header and one with no argument. Sorry for not >> catching that when reviewing your initial patch. > > No worries, and I agree the documentation should be updated. I'm happy > to provide the patch myself, but I'd like to talk through whether the > current implementation is the correct one before I do. Thanks. To avoid any confusion coming from this description making it into the 9.4 release, I've updated it in 4b2123fb7.