From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6EPXC4SIY2Dd4AAAgWs5BA (envelope-from ) for ; Tue, 30 Mar 2021 22:22:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id li92BYSIY2BkUQAAB5/wlQ (envelope-from ) for ; Tue, 30 Mar 2021 20:22:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E2FB2515A for ; Tue, 30 Mar 2021 22:22:27 +0200 (CEST) Received: from localhost ([::1]:39256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRKsc-0005lV-Nl for larch@yhetil.org; Tue, 30 Mar 2021 16:22:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRKs6-0005l8-2A for emacs-orgmode@gnu.org; Tue, 30 Mar 2021 16:21:54 -0400 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:35450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRKs4-0001rZ-BT for emacs-orgmode@gnu.org; Tue, 30 Mar 2021 16:21:53 -0400 Received: by mail-qk1-x72d.google.com with SMTP id i9so17198564qka.2 for ; Tue, 30 Mar 2021 13:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=SL1OLszsP8keEfMh83F4jH/EJlKGGVm85jxnPLkFDmk=; b=Se5tK7uxjtNqHpx70SQ9NoVMY0qDIdhWGegI/9kiSoZddx79+rREwTvUCtTb+X0lbF ME+Y+mS3mA6OxxXODklIyCMcfAznU/y8z7k3ToIjZDasF/andPaO2fKDKqlGPba1QxP1 9w2bLBSmUOy2Uf4egw+IZwNwQK92AAUuUg3Nhz52OntX5Qtyh7vkHPRpVpXxodyzbAgc HtvATEmq9mcsHwsTxqZyVWvKNqtz+xINx3xa6QKVToaVyAuDOdCMbUgUVUDwObksM1hE rqIrh9B+/BUBXxCTpo14KKpvSE7zuGCCzSFL5EBDUMxIMCwG5fAFJ4zx63gX8iEAfUqf nW4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SL1OLszsP8keEfMh83F4jH/EJlKGGVm85jxnPLkFDmk=; b=KJeyP6yUI4KTx3dpq9TStjg8aLBJHgwoE4WAV4leUxuzg/GIyn9FaQlpoiUcW5L5o0 aXhXq9I/UNkexPdW5S2pTGnlXD5+sg73I1qXaK724zwZI5equnzyjBoNeFRqwsWRH0bY 52PsEc7L4oD30vVPrViCWb0emVSCUQ0IhrC37a75BP1Yl1wK7cjWORpxFE81BqTIasn6 lim1uYe9zyE0Zmb6wdtYCf9rl44dMPNPfwACXtRZCZGQkLgq9yK/4AQhGwEPv49jhKrd GoHJxgpRBAlKT+LxpvWXKC8CHuUT4TIPk+qUfUE/32CEhj1sffVEiGSwvEx0Td6Inmt2 P2CA== X-Gm-Message-State: AOAM533IvRYnLVq/b46Pjnm/hgBktIAoLr5JwoVnTJ1+mGgzpOxbNhW5 5Q09Yo+Cmp63ioqdiYMC6nvtV4/Dn2s= X-Google-Smtp-Source: ABdhPJzblwHkJAxzHMd/vTH6Qt9PpllokOQlEOyNQrlRAVXIn+yAq6hRA8cbrZOa75jknmhS8Lu30g== X-Received: by 2002:a05:620a:1467:: with SMTP id j7mr38265qkl.136.1617135708095; Tue, 30 Mar 2021 13:21:48 -0700 (PDT) Received: from note ([201.62.67.247]) by smtp.gmail.com with ESMTPSA id m17sm16655796qkh.82.2021.03.30.13.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 13:21:47 -0700 (PDT) From: Renato Ferreira To: Kyle Meyer Subject: Re: [PATCH] org-agenda.el: Rename org-agenda-format-item parameters References: <87tuozgh75.fsf@gmail.com> <87wntp2uql.fsf@kyleam.com> Date: Tue, 30 Mar 2021 17:21:44 -0300 In-Reply-To: <87wntp2uql.fsf@kyleam.com> (Kyle Meyer's message of "Mon, 29 Mar 2021 23:20:02 -0400") Message-ID: <87r1jw5r53.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::72d; envelope-from=renatofdds@gmail.com; helo=mail-qk1-x72d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617135747; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=SL1OLszsP8keEfMh83F4jH/EJlKGGVm85jxnPLkFDmk=; b=X1z7s0uBTMWzuYhL2OfB9U5+hyT0Q29jVvKVIaBPXkPgdEOBEatJphI5utICDpzDoL6DEi /IWAFK1wt+jEpeJxvRgv1IiQZQVK/BircHiUicJLVuMv8oXParEWLObKwGoh/VH1XNDJEG 73EKwDnbQv9kCGf5UUQ4gA10R2k1IZDKPP3ViG6Xsbs1xKIwsq5Y9cidyWI1grBQTxOV3f rVqXbJkV7diWFVNe+FNsmjQ3cLAAku7dQPJYutwlQGk+EWgy/jsh34WgjSDdmBfrrwNPZ/ sjZabOKpcBuYdAIEwI0nQMCJU5lKcf/sqmvZoTjCyPsUliLwuEr1G2x1IEk+3Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617135747; a=rsa-sha256; cv=none; b=B+mmDAb4T94I8QXWpOyKgpI9lFOwSWVNxctSw4s1/5+xv3A19HLHChXvnFRA+iR7p9t9T7 4or+0P68kV6VvTYOwZZSP5wS5w8nt810WA2+Wp7UqM1iHI0ENeZvnT8L5tBd++ua94yCem 8hR2w2OHNiQLgRnSffypEHGYCUm3wUC6ZZgAi2b0L2MsbUHbvHwWmIYZmS2mOxfYMjQ3uO emglbC0nGNcl1/CbR2V0n8+13avT0KqiNYVcrrdcjlnxFEIw3z3m1/PnSu0JE5i+EoNkoy coEFwZKA7gVORKXcyhBKwiasVWLheAWpNBUinnRIbLplu7wYLlq9C53Try9K8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Se5tK7ux; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Se5tK7ux; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7E2FB2515A X-Spam-Score: -3.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3ouZ1SJbWm8V On Mon, 29 Mar 2021 23:20:02 -0400, Kyle Meyer said: > Presumably you arrived at this patch because you hit into a particular > issue (related the lexical binding conversion in 129c33ddd). > Could you provide a reproducer (or at least a description) for that > problem? That'd be useful for reviewing this patch, as well as > assessing if the conversion has other similar issues. Sure: ```org * TODO Header ** TODO Subheader * Setup #+begin_src emacs-lisp :results none (setq org-agenda-prefix-format '((agenda . " %i %-12:c%?-12t% s") (todo . "% l %i %-12:c") (tags . " %i %-12:c") (search . " %i %-12:c")) org-agenda-files (list (buffer-file-name (current-buffer)))) (org-todo-list "TODO") #+end_src ``` Note the "% l" on the todo format to use level variable. Evaluating this will result in "if: Symbol=E2=80=99s value as variable is v= oid: level" in commit 68db6fc06. --=20 Att., Renato Ferreira