From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KDjtDM/0YGJULQEAbAwnHQ (envelope-from ) for ; Thu, 21 Apr 2022 08:08:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wOEfDM/0YGJk3wAAG6o9tA (envelope-from ) for ; Thu, 21 Apr 2022 08:08:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D37A725C23 for ; Thu, 21 Apr 2022 08:08:13 +0200 (CEST) Received: from localhost ([::1]:37280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhPzA-00007D-7J for larch@yhetil.org; Thu, 21 Apr 2022 02:08:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhPrp-0003SF-MW for emacs-orgmode@gnu.org; Thu, 21 Apr 2022 02:00:41 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:41800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhPrl-0002RX-PD; Thu, 21 Apr 2022 02:00:35 -0400 Received: by mail-pj1-x102a.google.com with SMTP id z5-20020a17090a468500b001d2bc2743c4so4242024pjf.0; Wed, 20 Apr 2022 23:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=MhMfkEikx9IWxpQ7U58JZL87KEP/La3ULxgnDZczR00=; b=EMvYQ5zza/BOMXeJ9OwLg87+wyb5SDS6p4YXGGKrxgtN261TO6NN/dCkQW/8mvlUtI HbKTb0vy3fdcZMssSe4v1CH3MNrYDbYnDh0TjjnFaO1z4ktTMsE4TEEe7xq3snCtzKAS HFGqYDiATnC1yOJQSiZcNRaz+xS2LDbEY7vPWF1oBeLEv5PfS09BCzQdVvrkTcPGyfjr QAXNPungasWQVBMrZpz0nALkXCG2/Vpc1CMC8iNQjKJEVkKHVDp7/bpDqykBYf5Q7+AL guowgt+MC0Erkyp7stlkdndVW3HXvvaEyMsNcwClqTX/uxq8DI6ffZ9XCNYAyJaEEXPV l0sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=MhMfkEikx9IWxpQ7U58JZL87KEP/La3ULxgnDZczR00=; b=q1OFpgTXnITCRXpMid0SUsl+k2D/YMC0ZEPE7SlRS/4UzwGjZQxtG8+hlTM4+nCYS6 zoyTbbmBzRfu95DqCYArY2ay7Rfr9Vw9uDPdeiz0IKEW0B70W65VxkgMGuwULrikQ3+5 fzWVCK2yF/f8qAUIo2uGsu1vq8lfqd/nrAyrh0vbIQhYPJhBQJ2cLLNevpz/mxZATGcb s6sqwyZ3m5vTdgpXbtcOULRZbbrFPW3NEM9K9sidky9XR2TJD/VtFPTRxiWiKVZuMY0q F5C0ckAj7QFU2sZpzAHYmNvQGBU/j5j5D0AgfLweUF9ztgo+q7Vogm+kby28hlf3HeAX eEFg== X-Gm-Message-State: AOAM533KWuPLVNwfukeGullX2V0juISQb6XamvkRm7FmGL8HHaatyXB2 EjCDKQcuI0O6FiaMubrfVRaqmll2Hd9KFw== X-Google-Smtp-Source: ABdhPJwrom6hRqMpEUiY9RIqxeqAbluqDYZIwg/KkRUaRlvFn+jCGFHl4FChlXZp7PZhAib64fVZWQ== X-Received: by 2002:a17:902:ea57:b0:15a:6173:87d6 with SMTP id r23-20020a170902ea5700b0015a617387d6mr1895849plg.104.1650520830146; Wed, 20 Apr 2022 23:00:30 -0700 (PDT) Received: from localhost ([64.32.23.62]) by smtp.gmail.com with ESMTPSA id j13-20020a056a00130d00b004f1025a4361sm23938532pfu.202.2022.04.20.23.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 23:00:29 -0700 (PDT) From: Ihor Radchenko To: Bastien Subject: Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch In-Reply-To: <874k2n9139.fsf@gnu.org> References: <87a6f84edg.fsf@localhost> <87a6cfak1y.fsf@bzg.fr> <87k0bjg3z4.fsf@localhost> <874k2n9139.fsf@gnu.org> Date: Thu, 21 Apr 2022 14:01:22 +0800 Message-ID: <87r15r3rgt.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650521293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MhMfkEikx9IWxpQ7U58JZL87KEP/La3ULxgnDZczR00=; b=GMrd4laKhFUh4kORd869hSm0htaloO+uK5Fny5m2jRy/ZkezAitQ6rSwMt+DbqKlZrtjsU rxFhlRmi3WJQsEkhugIAs8/6mx26fTM+UXlT5940KQJgvylpZE88Jm94dwseqqIgsIieUL 0mFT9rDs8kN0xUM3WZXYOb/BFiUMIR9p0yXRdVyKcWvr6cA0nBNJCkC5RwS2tKneB6Eyn6 4ERUX2nFgAAfxo3Yg1HBSQdondAEA7iWNOx7oMzl24/K9paGNHPe+q0ju32RHNzyxE6Jmm 2Dv0EzWTBITVC8xzLC/GCeli9WptXRlyfZBihvSHDbI8w3BNL9LCzeZ+Mi0qTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650521293; a=rsa-sha256; cv=none; b=O1E/k7tNjfRc78LE8Ps5N83iE8lDK3VAJN6vFmudVd30gosbOy5HIQ1NEjBTrPZIedfMJk 9/EYBI8ypGsKo0puzvGdteVdbkzXO3brsSIfePI7FPnXIsqk2kLu1BoUg7uLI5t8dsUHg3 vW8zcljlf42jb4ulrNSMIVfuI3m5mDVKHdOU8m4rwQczNwRGVDyn595chjMKej5Taln6hx Siu4mK1mgenWgTiMHkJnTAC3ZAWa3aGYorIiH7w9BRpQN6Rkc0M/cayNAJENCgwLBXYtR0 +vpBCCPxhdPoGkRvRIFhEjXcsfqPkDmaLa7jiYnn+uvjPbIGjh5hRVuvRTa1JA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EMvYQ5zz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EMvYQ5zz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D37A725C23 X-Spam-Score: -2.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: Cl80ebjaWoiy Bastien writes: > I'm on commit e0abbbacf9427b69482c6c47c3ea0975b0e6fa6d from the > feature/org-fold-universal-core branch of your org repo. > > Using Emacs 29.0.50 and this as the content for ~/test.org: > > * TODO [[https://orgmode.org][test]] > SCHEDULED: <2022-04-20 mer.> > > Then run: > > - emacs -q > - C-x C-f test.org > - M-x org-agenda RET > - < a . n t > > You should see the link losing its invisibility specs. I did see it in fork/feature/org-fold-universal-core and it is very strange. The properties are suddenly lost after running add-text-properties and things become normal if I simply move add-text-properties above org-fold-region in org-activate-links--text-properties. What is more strange, the actual patch I proposed (fork/feature/org-fold-universal-core-tidy) does not have the problem. At least, I cannot reproduce it with you recipe. And the patch have exactly same org-activate-links--text-properties... Since the actual patch does not have the problem, I'd prefer to ignore this problem unless it appears again after merging. Best, Ihor