From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4OJqEyJYRmNuCQAAbAwnHQ (envelope-from ) for ; Wed, 12 Oct 2022 08:01:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qEONEyJYRmOJUgEA9RJhRA (envelope-from ) for ; Wed, 12 Oct 2022 08:01:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0CA7D3BC03 for ; Wed, 12 Oct 2022 08:01:06 +0200 (CEST) Received: from localhost ([::1]:41182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiUnh-0004Is-0s for larch@yhetil.org; Wed, 12 Oct 2022 02:01:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiUmF-0004IX-RN for emacs-orgmode@gnu.org; Wed, 12 Oct 2022 01:59:35 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:50727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiUmE-0006jN-3E for emacs-orgmode@gnu.org; Wed, 12 Oct 2022 01:59:35 -0400 Received: by mail-pj1-x102c.google.com with SMTP id h12so8660791pjk.0 for ; Tue, 11 Oct 2022 22:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Z6qnAygSSjjlvtlx0sysKQEXsh/JouFDO2Anz4McpQc=; b=A5uZEr/sejEmo8smr7V3pOk9IVFxImnAms5dcksz1OLveb3ew8WV0wFYkO4beBDojN eFYdZEhxedtI9rJW/LthgvS7ORqPjh09kqjNQ3WXuTz7R39lCp17h0SiFThCLbssEhFV jm1rExNSBssZFTPLAXivxmNlWSJTeOA6LMTTiSG1/L08AiHREGpbtIPuxgzTmm7fHvVT uEvYskusd6nGTmOgg6yDp6gzm7KnBDmxU9yoi484TZoMDLLDFtWRuGCrOe6/GObQsKYl H7FMr3pUBivxqhPuI3kuQ2N9r9HVn0STOKjD1hXdKsMyt93+YuYgHPjlGJQ6LnpwdsRz 1YnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z6qnAygSSjjlvtlx0sysKQEXsh/JouFDO2Anz4McpQc=; b=kOGgvVq9TJ5Tn/0JS33f/s8E8eJFJ83PE4ae5oTh1KImRxt6Et2/7pLZMXXZlHlWqg RXihvLsQ9gDH+VymmwK4GOhIlmxAW1tGSt/aN8j4koxkXdjSps02ZQ8x6M7lk/3tbt1w +jKDbxndI3wbA3Uu2sgunClNkbc4cr+mjciJ22iDvZkE7XJ42J8cmEVLEPOpY5XxrckW nbj3QHfsNGGZdl6lQsKJumWxR/nPuSrzeQpdfv6/2omVGJNe4R0T8pczCmtYUR96WN/7 /NWHwZMfJzSqyuxsycIXjBcHb19PrzB+j9FrTp4+3NkDVNKNRI/UJZvna8aBIB5znThE F2GQ== X-Gm-Message-State: ACrzQf1wvnCuVnzCT3jnFYd4EY11V9XobN9gLNox7eNeT4o65+17KCqd Rb2CoGt4kHIAApW8c2eLKzk= X-Google-Smtp-Source: AMsMyM4QL4bnf9fHT2f1IWVKrlYWuvOF2Z9KviX34uSSl3U/5MZSkvNTPwXMXt6mN/P5eZ493Ss1TA== X-Received: by 2002:a17:90b:1a84:b0:20d:5086:3694 with SMTP id ng4-20020a17090b1a8400b0020d50863694mr3289562pjb.74.1665554372543; Tue, 11 Oct 2022 22:59:32 -0700 (PDT) Received: from localhost ([2409:8970:af2:32f:6c23:3ad5:f37d:541b]) by smtp.gmail.com with ESMTPSA id l13-20020a170902f68d00b0017829f986a5sm9754031plg.133.2022.10.11.22.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 22:59:31 -0700 (PDT) From: Ihor Radchenko To: "Fraga, Eric" Cc: Org Mode List Subject: Re: [BUG] org-beamer :BEAMER_ACT: ignored on columns In-Reply-To: <87ilksm8lo.fsf@ucl.ac.uk> References: <41d13343-d278-2474-ba8f-88d24621ab30@housseini.me> <01020183a6ddf08d-3a0a1b66-f39a-47ba-8222-d6db2cbf8992-000000@eu-west-1.amazonses.com> <87k05esmw0.fsf@ucl.ac.uk> <878rlt7isk.fsf@localhost> <87wn9dcrse.fsf@ucl.ac.uk> <87edvjpydu.fsf@ucl.ac.uk> <87czb2luad.fsf@localhost> <87ilksm8lo.fsf@ucl.ac.uk> Date: Wed, 12 Oct 2022 14:00:20 +0800 Message-ID: <87r0zdshsb.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665554466; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Z6qnAygSSjjlvtlx0sysKQEXsh/JouFDO2Anz4McpQc=; b=IKjfEAnFFP2IQ0qFqjfLPwqTr+S8wjMNm/Xr1e7ywEsWG87AWCJSZjg5b2yOg5W3MJcXS4 51TaYYM0m2OfwzdsYcInT0P4N9/s3Kgn49Qf8MoQlNynhn0mP8UIt4KF7PWf4SN00vvAon QuqXxnQ2plW4ZekM7476JlNKGYYmCTvPz75V8+RN7YTlGk546r69MYjNnWYVk2Sh4I8Q0+ frnijmzcirgFNh641Zm7D/Kr7A9iGWPzUcS+DlGgHvmzbfZAk8+a4QpP2PnsF6vb8ttSSx 9Z/hAqezFfhDXSu6GJSSkJ2AU/vXHP3Cz4yWhLH6rwyMTrt/M7+0MqDaCN+99g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665554466; a=rsa-sha256; cv=none; b=NGGWx4A3/CIFVceSGdKaNsbpLeOeEi7NXh5Zj278KvaRx6cVe135Mc08zXtOolsY2ardw2 syEqfMrHIVJgf/YfmZZwsHGLULwkMMaVyzjtNkI90DCY5vbqtdTZK2e7h4FgyrBD41AuDh s5jRDjrlYOr2mtr8PzkuURFcJnwj2K0wtla2rYWDZXx3Z2cMT7pfQAmKeE4SNh9nUCeNl0 iFoyYwSPaBP3AdEeFleevAMKcimbiTCXdQO05qAoUz3UTQ4zugZIK0CrCIUAb2NNrTGDll 4uEdZec5IeGjVJN/0ZrqOp7VQWgp4aIhwPfBRDsbBsrZN4n9/F/h22aEONh4ig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="A5uZEr/s"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.90 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="A5uZEr/s"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0CA7D3BC03 X-Spam-Score: -6.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: EgVHamFY9eH2 "Fraga, Eric" writes: > On Saturday, 8 Oct 2022 at 14:10, Ihor Radchenko wrote: >> This patch certainly adds code duplication and might also miss some >> scenarios considered in the environments from >> org-beamer-environments-default. > > I'm not sure what code duplication you are referring to unless it's the > two lines that now address actions and are similar to those for options. > The comments you referenced are from the original code. Let me elaborate. Your patch adds for columns ;; also process actions (raw-actions (org-element-property :BEAMER_ACT headline)) (actions (if raw-actions (org-beamer--normalize-argument raw-actions 'action) "")) but the existing code also have (let ((action (org-element-property :BEAMER_ACT headline))) at least :BEAMER_ACT is acquired redundantly. Further, the old code has ((and (string-prefix-p "[" action) (string-suffix-p "]" action)) (list (cons "A" (org-beamer--normalize-argument action 'defaction)) (cons "a" "") (cons "R" action))) (t (list (cons "a" (org-beamer--normalize-argument action 'action)) So, depending on the :BEAMER_ACT value (if it is enclosed into [xxx]), it is parsed differently. --- I do not know if [xxx] vs xxx makes any difference for columns, but it is generally not very clear why there is a distinction in one case but not another. If using (org-beamer--normalize-argument raw-actions 'action) unconditionally (rather than 'defaction or 'action) is ok, at least it deserves a comment in the code. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at