From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wCLFB2trT2NYyQAAbAwnHQ (envelope-from ) for ; Wed, 19 Oct 2022 05:13:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ODAEB2trT2M6YgAAG6o9tA (envelope-from ) for ; Wed, 19 Oct 2022 05:13:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CED8635556 for ; Wed, 19 Oct 2022 05:13:46 +0200 (CEST) Received: from localhost ([::1]:57556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okzWb-0002ed-UV for larch@yhetil.org; Tue, 18 Oct 2022 23:13:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okzW2-0002eT-Kl for emacs-orgmode@gnu.org; Tue, 18 Oct 2022 23:13:10 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okzVw-0005pG-T6 for emacs-orgmode@gnu.org; Tue, 18 Oct 2022 23:13:10 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C151F240101 for ; Wed, 19 Oct 2022 05:12:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666149180; bh=GPqT84MjIcimfQRK7Z/nEW5EDGGTNGSFcYYdjaeldw0=; h=From:To:Cc:Subject:Date:From; b=ESUzensRoKg2TVkwllCfIAfu8o723sSWVgByjDyn5VBVj4W3WUGwLvBn670zRyx0i R8N6qVcIm21cdeRhLJ+pcWQ1Z4iA+W/CcrNopFEmq3+7HDL5U2lzrfw9NZR7uq+qyy RRV4Mt/52lFaek6OGsFjwYuwMoseWSe8l9nhPdbDyWyIEaefH2d2zFeZwC2QABJD19 wOq4S49mBdFnK9Rdx+itwwpkCPQa+L0bhBqji/yX8Iox/HocFvW9g5JihbHe8rsjWD yr0+sZShpNnjN8zPRLM8aSk5p28X8Md+BveVcToJrk1J0zKVp6knmQhfKahtJ+3haA 24I/nrIpsGHhw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MsbQK4vvhz9rxL; Wed, 19 Oct 2022 05:12:57 +0200 (CEST) From: Ihor Radchenko To: Alex Giorev Cc: emacs-orgmode@gnu.org Subject: Re: A couple of `org-priority' fixes In-Reply-To: References: Date: Wed, 19 Oct 2022 03:13:44 +0000 Message-ID: <87r0z4cxp3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666149226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=14CZ7WnS1rv0p3qvA7oikb3l7khkMXaLtj3ZAE/jkdA=; b=uuanu7DeGj/x5jG3mE9lB7eQFXs2MJCqGxcQMZwGHKXe6NdbUtKV9EUXYPF+4d7/DkYIXR IZu2pbnV12Ie1tcdqHqKvl7rUF5uNzvj0k6TJWKeuaniKvqZvInR0q/GgPcobNzUC1oAqI UtQ/UxBOnVzGzMWbReKRFQ2oMmxVM2po9sYwQDfqV2sw1yXA2f1E0dOkqrKs5TQGitHMbN x1Gz9Jm7fjjOqRAvkG26Gz1ivuuwjdjJndp+mKIqj5wugiIgQDaQGGflq3P/EoYS6oNZbK QOAJSPKmFREEHKMZ0Z5DoIJH0GiNZyoHOE9KvhaHUYfdK9YR6u8b8B2EdHOqOQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666149226; a=rsa-sha256; cv=none; b=RaRKjUs2jEfotNuxi91Qlx47TBKi4679LOMy04KNXxQZiEL1wsnCoDtKnsZwSh2JXk2ks3 pOLyCaDg/3d8576w30Uxq3b+ZWn4X4wii+jw30pguIdzxsBY0O6mNVVM1/S9YKWxAG6lJa s+SObBvsh5PbFnRXRFagmMGcggLAKUaKGnpTLpFEnC3ddkS1W0GAS/9Q/UmnHQSVwN70y3 Iek1M3HtzGprUxhE2TTBlo/nmumedvlLOtx9eCjU95pbnybHGODjRsCkql1uOmvHgi0t2Q otRfdLQd0bQ/KKfimNaaO92o7rzyAh8Vwsp/A+OdVOXpyS0ePcbo1oxmuxcvDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ESUzensR; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ESUzensR; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CED8635556 X-Spam-Score: -2.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: j2hFK6rFs+nu Alex Giorev writes: > I found a couple of problems in org-priority, I think these patches fix > them. Thanks for the very clean patches and sorry for the late reply. > - The first patch is truly minor, it just adds a bit to the docstring > - The problem which prompted the second patch arises when all priorities > are lowercase (you can test this by evaluating (setq org-priority-highest > ?a org-priority-lowest ?z org-priority-default ?o) and then trying to set > the priority to some lowercase letter) > - The problem solved by the third patch arises when numerical priorities > are used and 32 is given as the argument, 32 being the character code of > the space character, because that character is used to signal property > removal. I have tested your patches using make test (see https://orgmode.org/worg/org-contribute.html#first-patch) and it appears that your patches break removing priority from a headline. Can you please fix this issue? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at