emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Bruno Barbier <brubar.cs@gmail.com>
Cc: Damien Cassou <damien@cassou.me>,  emacs-orgmode@gnu.org
Subject: Re: PATCH: Re: Reading the parameters of a special-block
Date: Thu, 20 Oct 2022 05:31:33 +0000	[thread overview]
Message-ID: <87r0z383ii.fsf@localhost> (raw)
In-Reply-To: <E1olDZU-0005vE-Ky@lists.gnu.org>

Bruno Barbier <brubar.cs@gmail.com> writes:

> I also added a new independent patch, to fix a bug when interpreting a special
> block that has no content, and some tests.
>
> Let me know if I did miss something,
> And thank you for the review!

Thanks! LGTM.

Now, can you also make a patch against https://git.sr.ht/~bzg/worg
adding the new parameter to https://orgmode.org/worg/dev/org-element-api.html?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-10-20  5:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  8:37 Reading the parameters of a special-block Damien Cassou
2022-10-17 19:28 ` PATCH: " Bruno Barbier
2022-10-18  4:56   ` Ihor Radchenko
2022-10-19 18:18     ` Bruno Barbier
2022-10-20  5:31       ` Ihor Radchenko [this message]
     [not found]         ` <notmuch-sha1-5aa2ae4e8031bcbe3c55fd813dfb0f61229b24d1>
2022-10-20  9:45           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0z383ii.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=brubar.cs@gmail.com \
    --cc=damien@cassou.me \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).