From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QNxHI22IvmP2ZQAAbAwnHQ (envelope-from ) for ; Wed, 11 Jan 2023 10:59:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uFgwI22IvmP9UwAAauVa8A (envelope-from ) for ; Wed, 11 Jan 2023 10:59:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1258F1093A for ; Wed, 11 Jan 2023 10:59:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFXs6-0001mL-7Z; Wed, 11 Jan 2023 04:58:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFXs4-0001mC-PE for emacs-orgmode@gnu.org; Wed, 11 Jan 2023 04:58:12 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFXs2-0001te-Io for emacs-orgmode@gnu.org; Wed, 11 Jan 2023 04:58:12 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0457C240435 for ; Wed, 11 Jan 2023 10:58:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673431088; bh=xpBEX/sFNySnRDADU67bpOvnihN97LpW60nCRCF33Sw=; h=From:To:Cc:Subject:Date:From; b=UJ8fkZl21ZD3683wrKADA9HgbuECN4wUQd0XzklWldweDEyA8hyU3+Ubkhrxh/ZYh e4lhQEam/M0ZnImH8nUwFwnaliwkBJjGFUqh6v2iywwyJPqRZN5ZncHQtfxuTASGyi MXMtHh49W92I5t09QJG/UmYYRs9PAULtro+gRJRsHKNfkRhqOXojaZOM/xeUwTd3li bcaxU8FvJYhOXSbSUju7PduAEbqSJQE2CQX53+hhhiMpuQn4b4ZVdTCWuzw2f941vt Att1/FEj1STC4p/MYkCHtew7QImlP26/ZUz6NPJohHhGiDF0TeKxEmFbJ/ICYvuV2g QsWsJ9gRkTNjA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NsNR30Kbgz9rxR; Wed, 11 Jan 2023 10:58:06 +0100 (CET) From: Ihor Radchenko To: Sterling Hooten Cc: emacs-orgmode@gnu.org Subject: Re: [FR] Please add writing to existing heading in org-bibtex In-Reply-To: <0FD9DD13-EA96-440E-B873-571DA364B274@gmail.com> References: <76ED509D-E464-4B3E-B751-B233340B2E94@gmail.com> <87cz8424b4.fsf@localhost> <0FD9DD13-EA96-440E-B873-571DA364B274@gmail.com> Date: Wed, 11 Jan 2023 09:58:39 +0000 Message-ID: <87r0w1fl4g.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UJ8fkZl2; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673431149; a=rsa-sha256; cv=none; b=A+QUDa2CY1iAnWOMBnPhYsSYS8i5XuFXl8cEmlrLJBxFRQjUKRXGJ0bHTPXpztP+GN05sE +um58/CUqsZpMxuIiv7bPjGyUDIys3/cicsTofrTyQZtvgJc+xERs879czgR4G51juDB9F wzZzkt8Ske8/aSgplOU8RvsvPpJA3k2MBfOYlhRW1O9jVzzbyoLVdBYqj8rRF8ML58wHRa PhWNO8pfRWxgdKLjCodHUwBlcsKcKgd4xytc1vg4anrV8DlI2HVb2VVv+1s9kMXc9OBCBh lf2jv/+iQQjCtHpH4KTkPe2t7wQUWo0ursZwy83S+I058VYk4wlCVOLN8nRrhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673431149; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Y0oVGAy1BVbmI05IXyMtdkMFHmwwG2h0kZvwNDgPgoE=; b=QgW5Fv2ReGWupeccStm/i6huWSQSgOOUDKF53dEoV3mLFNf7wZcbx9cUZ27hvNvpphsyh1 pjeVD8WxPZg8mD2mBx/mD3soh7yaLy+e5RGSFyEDI0LgsgsegPO/MDVIcT54eehwB4QdsB AQqeqMY+ZCGGSkJCaAahed/jsWW+ept0gRC7lI8JO3ypssf/YhToGeyOrtdQdffNFrRkgp 1U955la5WSdNQOF5rkxFuKRyghgIneE8W4o8QmtrHCP1K3MDcQb6MvhQJEQxlVk1thkCaS HJi7y9hmkycaiY2WTnv1rekqoWVvMYyIXpSAHbMcF/jKk9wEGZuD6ONKThuVxw== X-Migadu-Queue-Id: 1258F1093A X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UJ8fkZl2; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Spam-Score: -8.14 X-Spam-Score: -8.14 X-TUID: FOPWjVk2+Dv6 Sterling Hooten writes: > Thanks for the instructions, this is my first patch. > > I think calling `nonew=E2=80=99 invalidates the argument `no-indent=E2= =80=99 as `org-bibtex-put=E2=80=99 eventually=20 > calls `org-entry-put=E2=80=99 which uses `org-indent-line=E2=80=99. I=E2= =80=99m not sure what=E2=80=99s the best way to handle that. You are indeed right. I suggest doing the following: 1. Change the function definition to (&optional arg no-indent nonew) 2. With C-u prefix ARG or ARG =3D 'new, update heading at point 3. When ARG is not C-u and not 'new, treat it as non-nil no-indent in the past "22.12 Prefix Command Arguments" section of Elisp manual might be helpful to understand how to check C-u programmatically. 4. If NO-INDENT or NONEW arguments are non-nil, use them unconditionally regardless of the value of ARG This way, the previous usage of the function will be the least affected. > diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS > index d4e9b4368..8eab4cae2 100644 > --- a/etc/ORG-NEWS > +++ b/etc/ORG-NEWS > @@ -513,6 +513,10 @@ use =3Dattachment:=3D style links instead of the sta= ndard =3Dfile:=3D link type. If you can, please create a proper patch with commit message, as suggested in https://orgmode.org/worg/org-contribute.html#commit-messages You can also refer to https://orgmode.org/worg/org-contribute.html#org8a3a431 > +*** ~org-bibtex-write~ can now write to heading at point with optional i= nteractive argument > + > +Previously, a new heading was created. Now with argument =3Dnonew=3D the > +bibtex data will be added to properties of heading at point. Please use double space between sentences. It is our convention. See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/doc/Documentation= _Standards.org=20 =20 --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at