From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uPyXMG18Y2QshgAASxT56A (envelope-from ) for ; Tue, 16 May 2023 14:51:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IEFuMG18Y2TsXwEAauVa8A (envelope-from ) for ; Tue, 16 May 2023 14:51:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5ED242CAA8 for ; Tue, 16 May 2023 14:51:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyu7m-0007sI-8I; Tue, 16 May 2023 08:49:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyu7j-0007eg-NL for emacs-orgmode@gnu.org; Tue, 16 May 2023 08:49:51 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyu7a-0006VS-8F for emacs-orgmode@gnu.org; Tue, 16 May 2023 08:49:51 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f41dceb9d1so110367975e9.1 for ; Tue, 16 May 2023 05:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684241378; x=1686833378; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dxWUKoPyBgNGITIJD9GHmN4npwL2fjI4tG5ARhlkCIE=; b=ozpbLdRKX4qcY7azxpDtpRTUH7FQFw47bJGQJryZVpsVdVY60m7x9x5NmiM7Y+Z4Qs sD4oXu0QhJ+qOIRrUZ6uLAlRbGkjIjcwS5DecbyBvJCVGUX12U5KANzc7izM/faxxqnx su2hybALZP9YeM/xhZ8e9m+seG5mKwBC71HvJSdm7DLAbHeuUqJgnwGfxOKvqq1NG1gL CFXUKHUKm/t+0+jGdztaZ3S1Mez6hCys4zyZ6zavr8FvR+m6jyfg5vk7TMXT2gCUg+Hq SVSKJSpuKOaRt6LrjnLCO4YizTZOy6BXZyGhiBDantiEWS1EPb6DQyZWH/gcVc2G+EVy yDRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684241378; x=1686833378; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dxWUKoPyBgNGITIJD9GHmN4npwL2fjI4tG5ARhlkCIE=; b=DUR4oljVmex+QP9kgC7yUat1Ju04CGkE90mz7ic1YSkmna2EjTR+0GI5rUH/r3ELX0 aW78WAq84CPfKV8nHFY3HEkXMlltJ+DjwoKeAzV7celtzR+g9YCT9Isl3CdU6v7IC/bh 2IlPUuEhQbrFMzUmAL3EEGcjhaCRmZbjy12+Y7aID/gbu/XecsCGlobKFxY4nyVLloZz EpGk6TnJbwsU5fyUEJDWuIxxNEUwFj+/sx2dxtIev8sjd6iTGmkDS2ya4BTegHB0S4sI mQ/OWZhf63a8+B0T2P2dSDT5RjbR5VJSqYrYfarrnMklyEk/1yhUokw0HuoM7mRtjrl9 xrmg== X-Gm-Message-State: AC+VfDz6tRW74AdbOe4+i+xnWLb8+6ejmq4/zJy8UqTbz0AvxEWeTUu7 eGo/2KCUVtJI6I1wxl9F2us+NfACtkI= X-Google-Smtp-Source: ACHHUZ413lXaXhGUWmeXxW3JTOLO6IEYZhO/Z2ad7wWvER6scxKWaYCnfMVjqrvQL8U6GRXFMZg/oQ== X-Received: by 2002:a5d:6645:0:b0:306:35d2:c33a with SMTP id f5-20020a5d6645000000b0030635d2c33amr25512182wrw.50.1684241378503; Tue, 16 May 2023 05:49:38 -0700 (PDT) Received: from hayvan (pharma2-70.w2k.pharmakol.uni-freiburg.de. [132.230.165.170]) by smtp.gmail.com with ESMTPSA id m16-20020a7bce10000000b003f421979398sm2247034wmc.26.2023.05.16.05.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 05:49:38 -0700 (PDT) From: Mehmet Tekman To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [ANN] lisp/ob-tangle-sync.el In-Reply-To: <87zg69zq49.fsf@localhost> (Ihor Radchenko's message of "Fri, 12 May 2023 12:33:10 +0000") References: <87r0rxabd4.fsf@localhost> <87sfcd78vw.fsf@gmail.com> <87r0rxv3t5.fsf@localhost> <87lei577g4.fsf@gmail.com> <87lei5v1fg.fsf@localhost> <87fs8duyae.fsf@localhost> <8735451u20.fsf@gmail.com> <874jokbjsk.fsf@localhost> <87zg6ch2dm.fsf@gmail.com> <87sfc4a0ce.fsf@localhost> <87r0ro9mzc.fsf@gmail.com> <87zg69zq49.fsf@localhost> Date: Tue, 16 May 2023 14:49:37 +0200 Message-ID: <87r0rg1lwe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=mtekman89@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684241517; a=rsa-sha256; cv=none; b=f9HB2U+ZJb/sBDXRT7vfmaq1F4tkIXrtGyLmsSyVkIxvEBYJB5XnCu1HMqdRwHXYxkR/OG wd+Os3m7tH3O/IStHcUnWHBMuUzV6YWAYudcWTR1ljsQO2/3LvBqZjdxKyvqc9Svgsn0W+ sX02i/3yjTGEKCsEhDbmKzWBFhX4EycfuE9rt8T9lzkyt4sDAaLRKENtz+4kkxxufqiGbu oOUZY9An64pTtv+0cZ2y8FyVIp0Rp4X4GHuU+XbihuUZDwnrqcN7rXVaGSO9t3XcSfSluz YoOPgvf9rkvp2yyoASC7Yq92D/6k7FI1kTi/Z+/ytDvTbSJFyU1ssjAWbEPWgg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ozpbLdRK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684241517; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dxWUKoPyBgNGITIJD9GHmN4npwL2fjI4tG5ARhlkCIE=; b=hnaPWoLKzCy7kB9i9M+UrPqDOx1F8efRWv4I1RUP6qY1n/IqW4C3/3BOm+KBj4Rt8eqOuS rPWBBBXVT6+Uh99jVQextRHCnukGsJXmnwXizxNeWrY21yVYNg6LkZ+fgVBp2ao3/V122G kUH3XrbqF5ofDVm3H2inoRTfa0wg4NFtMO7P235CE8SVu8H7ZGHRtqb+R9WtAPCv6ytHh5 +jI8fa/+V/9AZlmrmz8DH8yjFwSgVJVxzxf0w3u7BkoWNLJqWP3Kvxm9d9WYPAudvJUNDs K7tTNj/xOexswiMgql9SV4C28MqIjsqnTO1L25idsrmZIR9TE3hKYjxwjrXI/w== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ozpbLdRK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.37 X-Spam-Score: -6.37 X-Migadu-Queue-Id: 5ED242CAA8 X-TUID: liImPm52FQz0 Hello, thanks for the last review and sorry for the lapse in communication. May is proving to be a very strange month. Ihor Radchenko writes: > Mehmet Tekman writes: >> >> I've modified the `merge' function within `org-babel-merge-params' so >> that the main logic now accumulates a list of potential candidates that >> could be the :any keyword, and selects the last added candidate as the >> match. > > I feel confused when reading the modified code. > Okay, I guess comments are not my strong suit. I will try to remove any unnecessary comments and use better variable names. >> It all seems to be passing tests, though I would like to add my toy.org >> file to the org testing framework at some point. > > I recommend trying various edge cases with your patch. > In particular: > > 1. Testing exclusive group inheritance when we inherit a header arg > value that matches :any: > > #+PROPERTIES: header-args :tangle "foo.txt" > #+begin_src ... :tangle no > > #+PROPERTIES: header-args :tangle no > #+begin_src ... :tangle "foo.txt" > > #+PROPERTIES: header-args :tangle no > * Heading > > :PROPERTIES: > :header-args: :tangle "foo.txt" > :END: > #+begin_src ... :tangle yes > > 2. :tangle "file with spaces.txt" > I think before I do any more disastrous changes, I will try to expand the existing ert test suite to incorporate my toy org file and your above examples. That way I'd at least have a consistent framework to validate some of my work. > I feel that the following code is not reliable when we inherit exact and > :any exclusive group members in alternations. Ah, hmm - can you give me an example here? I thought the idea was that an :any string would only be invokable once for a given header parameter. Ihor Radchenko writes: >>> We should modify it. For example like the following: >>> >>> 1. We will assume that :any can only occur one time in the exclusive >>> groups. (Otherwise, there is no single definite way to parse header >>> arguments) Best, Mehmet