Re: [ANN] lisp/ob-tangle-sync.el

[Mehmet Tekman <mtekman89@gmail.com>]

Hello, thanks for the last review and sorry for the lapse in
communication. May is proving to be a very strange month.

Ihor Radchenko <yantar92@posteo.net> writes:

> Mehmet Tekman <mtekman89@gmail.com> writes:
>>
>> I've modified the `merge' function within `org-babel-merge-params' so
>> that the main logic now accumulates a list of potential candidates that
>> could be the :any keyword, and selects the last added candidate as the
>> match.
>
> I feel confused when reading the modified code.
>

Okay, I guess comments are not my strong suit. I will try to remove any
unnecessary comments and use better variable names.

>> It all seems to be passing tests, though I would like to add my toy.org
>> file to the org testing framework at some point.
>
> I recommend trying various edge cases with your patch.
> In particular:
>
> 1. Testing exclusive group inheritance when we inherit a header arg
>    value that matches :any:
>
>    #+PROPERTIES: header-args :tangle "foo.txt"
>    #+begin_src ... :tangle no
>
>    #+PROPERTIES: header-args :tangle no
>    #+begin_src ... :tangle "foo.txt"
>
>    #+PROPERTIES: header-args :tangle no
>    * Heading
>
>    :PROPERTIES:
>    :header-args: :tangle "foo.txt"
>    :END:
>    #+begin_src ... :tangle yes
>
> 2. :tangle "file with spaces.txt"
>

I think before I do any more disastrous changes, I will try to expand
the existing ert test suite to incorporate my toy org file and your
above examples.

That way I'd at least have a consistent framework to validate some of my
work.

> I feel that the following code is not reliable when we inherit exact and
> :any exclusive group members in alternations.

Ah, hmm - can you give me an example here? I thought the idea was that
an :any string would only be invokable once for a given header
parameter.

Ihor Radchenko <yantar92@posteo.net> writes:

>>> We should modify it. For example like the following:
>>>
>>> 1. We will assume that :any can only occur one time in the exclusive
>>>    groups. (Otherwise, there is no single definite way to parse header
>>>    arguments)

Best,
Mehmet