emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Nick Dokos <ndokos@redhat.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)]
Date: Thu, 22 Jun 2023 09:55:52 +0000	[thread overview]
Message-ID: <87r0q3ddnb.fsf@localhost> (raw)
In-Reply-To: <87bkh8k3at.fsf@alphaville.usersys.redhat.com>

Nick Dokos <ndokos@redhat.com> writes:

> Here's an ECM:
> ...
> I narrowed it down to this snippet of code in `org-babel-tangle-single-block':
> ...
> and bisecting fingered this commit:
> ...
> Apparently, `org-back-to-heading' sets match data differently now: `(match-end 0)' gets the end of the line,
> Before the patch, it got the beginning of the line.

Thanks for the report and for the detailed analysis!
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=79ec91584

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-06-22  9:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 19:45 [BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)] Nick Dokos
2023-06-22  9:55 ` Ihor Radchenko [this message]
2023-06-24  3:19   ` Nick Dokos
2023-06-24 12:37     ` Ihor Radchenko
2023-06-27  3:25       ` Nick Dokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0q3ddnb.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=ndokos@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).