emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-agenda.el: Fix org-agenda-write to avoid duplicates
@ 2024-03-03  9:12 Anand Deopurkar
  2024-03-03 13:47 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Anand Deopurkar @ 2024-03-03  9:12 UTC (permalink / raw)
  To: Org Mode List

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-org-agenda.el-Fix-org-agenda-write-to-avoid-duplicat.patch --]
[-- Type: text/x-patch, Size: 1439 bytes --]

From a269ee1d657ea11f998d294169cd9a88618409fb Mon Sep 17 00:00:00 2001
From: Anand Deopurkar <anandrdeopurkar@gmail.com>
Date: Sun, 3 Mar 2024 16:38:43 +1100
Subject: [PATCH] org-agenda.el: Fix org-agenda-write to avoid duplicates

* lisp/org-agenda.el (org-agenda-write): Make sure headlines are not
duplicated when writing to an `org' file, even if they are repeated in
the agenda view.

For example, a headline may appear multiple times in the agenda
view (for example, if it has multiple time stamps).  But
org-agenda-write should write it only once to the output `org' file.

TINYCHANGE
---
 lisp/org-agenda.el | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 8cb3496ca..798ef1a10 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3641,11 +3641,12 @@ the agenda to write."
 		  (goto-char p)
 		  (setq m (get-text-property (point) 'org-hd-marker))
 		  (when m
-		    (push (with-current-buffer (marker-buffer m)
-			    (goto-char m)
-			    (org-copy-subtree 1 nil t t)
-			    org-subtree-clip)
-			  content)))
+		    (cl-pushnew (with-current-buffer (marker-buffer m)
+			          (goto-char m)
+			          (org-copy-subtree 1 nil t t)
+			          org-subtree-clip)
+			        content
+                                :test #'equal)))
 		(find-file file)
 		(erase-buffer)
 		(dolist (s content) (org-paste-subtree 1 s))
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] org-agenda.el: Fix org-agenda-write to avoid duplicates
  2024-03-03  9:12 [PATCH] org-agenda.el: Fix org-agenda-write to avoid duplicates Anand Deopurkar
@ 2024-03-03 13:47 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2024-03-03 13:47 UTC (permalink / raw)
  To: Anand Deopurkar; +Cc: Org Mode List

Anand Deopurkar <anandrdeopurkar@gmail.com> writes:

> Subject: [PATCH] org-agenda.el: Fix org-agenda-write to avoid duplicates
>
> * lisp/org-agenda.el (org-agenda-write): Make sure headlines are not
> duplicated when writing to an `org' file, even if they are repeated in
> the agenda view.
>
> For example, a headline may appear multiple times in the agenda
> view (for example, if it has multiple time stamps).  But
> org-agenda-write should write it only once to the output `org' file.

Thanks for the patch!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8ac99c33f

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-03 13:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-03  9:12 [PATCH] org-agenda.el: Fix org-agenda-write to avoid duplicates Anand Deopurkar
2024-03-03 13:47 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).