From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uLxiCik7vmZ+jAAA62LTzQ:P1 (envelope-from ) for ; Thu, 15 Aug 2024 17:30:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id uLxiCik7vmZ+jAAA62LTzQ (envelope-from ) for ; Thu, 15 Aug 2024 19:30:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ef5+p2RO; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1723743017; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jJ0kWafPJMcBvmziXS11PSYujg4lWYN9l2Bjt6Mg2Vc=; b=eDBbSTFJYSbR0KnrZYTzyLuANng/37h/tOfuL3XDy7eseXjyXLkePdDPHSGGRr2G1BKbR5 exneUdc01aLwRQ1WOvOMtAGlQ/GJKLCV9Wm4h1LucLDUugcj4+C26xK7UVP1BSm2CNV8zw 9uPZXYclSXLxFs7Knh2CJpvmWwsALyt2Wdz+qofG96nd2/b85LxS4r0SWkvNL5nundyl/d N5rNa4icZ8YhgnM0DlXo6zS+pOGY76lB08hrdUXoIs2eFg5GKqbqkz+g6HY8mhQlThfger tZ5dBk2mYPafATVrGiHF7I6+4sr5NQMxf4zGQ7s+gok44UnAxa21zyTXeJbEQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ef5+p2RO; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1723743017; a=rsa-sha256; cv=none; b=AWDa9d9hFWAKJbiyt9t9xtXq/8TME4lACTrbi/LT+/TCgnAqZ6vKztzcdYSlZgQp3BI1dg KM1Iw/qRuShPoER8eDNYfLf5vpQ4kb2umU4l+0oC1OXgwec+GWDPv5RNwKgBv/jP162Q/8 8BowxdXs0A/rwMPKek7QpK+JqIfE6deHLEYbHVPCkwrNXDjoFnmwU5GefoBJ/6JpgtLMqZ ctK8KeeaN272LApEXHybueSukeUWSUNsEii05GFNNI9lwtyjpivq3CBi+ElNjxk2qr4GKB qZmXJiplXCeqesk638tN3s9MEZVdEeIIWuNn7lyJ+PaRWgi4RIZU8YtLHA/kiQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE4CE3BE81 for ; Thu, 15 Aug 2024 19:30:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1seeHv-0003C7-VC; Thu, 15 Aug 2024 13:29:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seeHu-0003Bh-Ts for emacs-orgmode@gnu.org; Thu, 15 Aug 2024 13:29:26 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1seeHs-0008VY-Cq for emacs-orgmode@gnu.org; Thu, 15 Aug 2024 13:29:26 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a7aa4bf4d1eso166797366b.0 for ; Thu, 15 Aug 2024 10:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723742962; x=1724347762; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=jJ0kWafPJMcBvmziXS11PSYujg4lWYN9l2Bjt6Mg2Vc=; b=ef5+p2ROUPbfWRD/oH11ejJPxun/HUUuOFYqnEOqAKL0nvRHgaRz26M35HZ6sd38r6 lMB+BlvUonLXCMgy2S3BKrZcRsh+xDZnVxM/XrFxjqtlK7Wf7Zl/yLT+4FI6KBk/dbGW uOAUwpSv+G9NjWrUSyBhLjTvXpNuYJ31qI4hu2D+0Vgmptp3NU7oSF4h5rdgTvoYVLV8 wPZ9OFi44I1SvLLW4Q589QOTijLFNNMD/bfffqN/iLV/Uja+WSx2oryWzsqL0WihT3Lo 78qotWZ3W3KlsUmsWCeFjSETtpn0xMnXh6HXDa+8l9hViYslbw9IbXlRiYPkW/rQfgjB 4YLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723742962; x=1724347762; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jJ0kWafPJMcBvmziXS11PSYujg4lWYN9l2Bjt6Mg2Vc=; b=FoT/DD9OBG5pAiMXVXR2+jUbzgnUHELFcqkkpSZ8dZ1VJ+s9c5EIRIttJAn1lINGkw sPl4fjtE1jwMqRbdvBab1J+6JrjP44QMZyaNkrqOE/uRsH/kJi/r88NbZMLZp8uXiIob eyCGGCZStqoSUaFXk4Akid/OxF200mbIZ5w0mCMI0JuJsW2m7c9dJwDzjVzhb7v0BzCs peiU2FDrxrONxx+FoSfKqMTpRDy/YbVWL2xpyvIOQHFE2LrUnjvBP6jgcwEF+HzW8Lzf ju0d2B+q8onybYEBLYyHvjrn0O6ypyl+M/Vj7coq/x6LHxYmBwUNtOjUbDCysQfO3gQl rbfg== X-Gm-Message-State: AOJu0YwC8hAHWx5QiE6P6YNaPBIvrr2toCWqIv6+Q/5vqW8+0TszQXPA KQISRmAZev+78S5UohzDA8JaxQqKRqqZlLJe9RQZL7b0a8UgCl6t42kEGw== X-Google-Smtp-Source: AGHT+IETs621pRrmTOjPdIgWIIYAr+c4vCHjOrSidDF5GHnHNEjLPPRDSlSb6zOYSi7mN3KRYPgqrQ== X-Received: by 2002:a17:907:d589:b0:a77:d7f1:42eb with SMTP id a640c23a62f3a-a839292e82cmr25422766b.23.1723742962147; Thu, 15 Aug 2024 10:29:22 -0700 (PDT) Received: from windows (83.6.108.108.ipv4.supernova.orange.pl. [83.6.108.108]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8383934564sm128133566b.126.2024.08.15.10.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 10:29:21 -0700 (PDT) From: =?utf-8?Q?S=C5=82awomir?= Grochowski To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [FR] org-colview.el, add annotation for functions summary-types In-Reply-To: <878qwx3f6k.fsf@localhost> References: <87plqiewa6.fsf@gmail.com> <87r0aw34yx.fsf@localhost> <87ttfllupj.fsf@gmail.com> <878qwx3f6k.fsf@localhost> Date: Thu, 15 Aug 2024 19:29:15 +0200 Message-ID: <87r0aplmok.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=slawomir.grochowski@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: EE4CE3BE81 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.79 X-Spam-Score: -9.79 X-TUID: KfimsrfbOnz2 Ihor Radchenko writes: > Why not applying faces? Because in case of 'annotation-function': https://www.gnu.org/software/emacs/manual/html_node/elisp/Programmed-Completion.html "...Unless this function puts own face on the annotation suffix string, the completions-annotations face is added by default to that string. >> (completing-read >> "Summary: " >> (lambda (s pred flag) >> (pcase flag >> ('t (all-completions s >> (mapcar #'car org-columns-summary-types-default) >> pred)) >> ('metadata (list 'metadata >> (cons 'annotation-function >> (lambda (c) >> (first-line-docstring >> (cdr (assoc c org-columns-summary-types-default)))))))))) > > Looks reasonable. > Although, I'd prefer to avoid lambda here and simply make it into a > proper function. Just like `org-tags-completion-function'. And this will be private function in colview.el? With name... `org-columns--completion-summary-types-function' ? -- Slawomir Grochowski