From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MAuZIS8SCGdPNgEAe85BDQ:P1 (envelope-from ) for ; Thu, 10 Oct 2024 17:43:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id MAuZIS8SCGdPNgEAe85BDQ (envelope-from ) for ; Thu, 10 Oct 2024 19:43:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lVFDcZGH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728580506; a=rsa-sha256; cv=none; b=UA4qLVq6TpxsezQ5s3U4UySJDPwSin3ND8lzLf2LrHDoeXc3kDvtoe758PZowSHHUdbLbr m1jH0eFVp8s/YNwU+NIr4v75essgArQI0IVrtJNvWTLGEST/s19A/ueJaPTfnXyadzKGuo kEEqwm29AD5OuhywTBfXGeBlutSJabSFnsiJlrvGb2WX5cAB0p+o9bVdJSO0XNq4d6XEGw wJfDZ95V+4Ef1pKKWLjXdRtRfw7AkjplAaWl3gq5ZAyZViQcmSVV9h65OxuZVEmGALWZfR uzhuC5Ld48h/ouyEMC83pt7OVhsCI/gOCLn7HTRnckwCdRdRjZ5pzbtZvOJ5xQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lVFDcZGH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728580506; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vMW6a8Vpf6SA0c5uM18Yh672WdO2caP6oS5hYhBKls4=; b=Q43fr1GLvRODUj1ywB11EdtbPF950ZlXW1e67XglMCSMnzeB2J/yldtcUerTMMM2TQj+hg SG2iCUKcwQQI8T1mDpxDG7AefzcmOQ3Q/UY4uAoy8S+5pcfwb9vHNn1EYONLV6ghcTKIV4 NxCFvOG+6qsMZFr0WG/R7OwXn7zu4GN9UuP5vHisY2VPaAQgcE+KUG2vFlWYi31OqxKR87 fcFJrEyn+ZqnAuFPcytxSq0SBrT1vfE8ydeQtFH2YqkgnC/G2El/dfFRJnX0HLjFpSHylT 2Relu4jITX+Don/Db41EVnjPEyTh+USuvIwdw8wnj2yhr9rhWKRs8IuHO3IyNg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2647880C2A for ; Thu, 10 Oct 2024 19:15:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sywjo-0004tP-0f; Thu, 10 Oct 2024 13:14:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sywjm-0004t8-Lz for emacs-orgmode@gnu.org; Thu, 10 Oct 2024 13:14:06 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sywjj-0002CX-3Z for emacs-orgmode@gnu.org; Thu, 10 Oct 2024 13:14:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1DAC5240106 for ; Thu, 10 Oct 2024 19:13:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1728580439; bh=puebncoOOoI2Dj0h3TTUSOIiv1uMqLryfUPQmCMUlVQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=lVFDcZGHfEzcNpl4x3lMCgtqOpRBdKVxZnfVz16NsaJEdzB3T2DVzKcW9lq8npDly hBQgFZQnEbtSR4ChfNOAL+DE1VcW98zYvGDO0V7jIJgOCA6NtBk1WAKF99tmtmiSIw onYfwq6k1IH4qnnCODM9giYww5PzGlFu66K4UuXC3t6oy4+/v09Ks/O+Ku+2ABHw6r DFlN2SL6HcWsPODPUcbq+Ua/iD6aDOD06WCA3sgm0HnPzT7W056WswFlKAWSieb3hf 83eQiaWQz2w32Ut60BVuwDgloKsM7yRYvYhNCsYiUb598IxoHJMC64GZWRePP78xJE OsO6X+FRD6F/w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XPbvV0pw6z9rxF; Thu, 10 Oct 2024 19:13:58 +0200 (CEST) From: Ihor Radchenko To: Karthik Chikmagalur Cc: stardiviner , Org mode Subject: Re: [PATCH v7] Inline image display as part of a new org-link-preview system In-Reply-To: <87cykbfodz.fsf@gmail.com> References: <6461a84b.a70a0220.b6d36.5d00@mx.google.com> <87r0ajawgj.fsf@localhost> <87a5h77zb1.fsf@gmail.com> <87msl4wv8d.fsf@localhost> <875xrqg6cb.fsf@gmail.com> <874j70n559.fsf@localhost> <87msksabld.fsf@gmail.com> <87jzfwljkq.fsf@localhost> <87h6b09v4o.fsf@gmail.com> <878qwb8qw1.fsf@localhost> <878qw9ak6a.fsf@gmail.com> <87o74ypp3b.fsf@localhost> <87r09rxpjg.fsf@gmail.com> <87h6ah72ui.fsf@localhost> <8734m060ma.fsf@gmail.com> <87o74mjgcy.fsf@localhost> <8734lx4twk.fsf@gmail.com> <87bk0hs4dm.fsf@localhost> <87tte7wdpj.fsf@gmail.com> <87y135ce4g.fsf@localhost> <87cykbfodz.fsf@gmail.com> Date: Thu, 10 Oct 2024 17:15:47 +0000 Message-ID: <87r08nkhfg.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.30 X-Spam-Score: -1.30 X-Migadu-Queue-Id: 2647880C2A X-Migadu-Scanner: mx12.migadu.com X-TUID: 2ADA2N8/WHGb Karthik Chikmagalur writes: > Latest patch attached. Thanks! See my (minor) comments below. I think that it is the time to move ahead with updating the ORG-NEWS and the manual. > (org-defkey org-mode-map (kbd "C-c C-x C-M-v") #'org-redisplay-inline-ima= ges) > > Do we need this command any more? I don't understand what it does > differently from `org-link-preview'. Calling `org-link-preview' with > the right scope argument (e.g. C-u C-u for buffer-wide) should > automatically refresh/redisplay images. We can simply make it call org-link-preview with C-u C-u argument. > I also don't know what to do about this warning: > > (define-obsolete-variable-alias 'org-plain-link-re > 'org-link-plain-re "9.3") > > org-compat.el:1184:4: Warning: Alias for =E2=80=98org-link-plain-re=E2=80= =99 should be declared before its referent > > I think this warning is unrelated to this patch? It is related. The warning is raised because you put (defvar org-link-plain-re) before the obsolete alias. You need to move things further down, after that obsolete definition. > +(declare-function org-link-preview--remove-overlay "ol") > +(declare-function org-link-preview--get-overlays "ol") > +(declare-function org-link-preview-clear "ol") > +(declare-function org-link-preview--remove-overlay "ol") > ... Good idea to provide arglist declaration as well. > +(declare-function org-attach-expand "org-attach") > +(declare-function org-display-inline-image--width "org") > +(declare-function org-image--align "org") > +(declare-function org--create-inline-image "org") same --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at