From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id OOTBIWCyCmccUwAAqHPOHw:P1 (envelope-from ) for ; Sat, 12 Oct 2024 17:31:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id OOTBIWCyCmccUwAAqHPOHw (envelope-from ) for ; Sat, 12 Oct 2024 19:31:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="Om7pbE/m"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728754272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LREIqDec6+jgrkEPsIlhlIfquQVlxAJl6WjFWc8I1V4=; b=Wso4zBJz9hPlBM2cnNtAdpWwoXN3PJSI0uyyRq2ufpSoxi+pUTZfyrJL48JaZaFljHvkuf fPZ4EvMoRShKf0MjwRWwFgIIQswyVWqAGJF+c0vbEkbxMdUIZr5sqarRshiCL8XbGPtKmy Ofn6RcN1lg5xqUlWh6jS5DHsuAXPNC1w4B62F2dmJgcvqJYvidS4Gl1OskEgqG8CV/VHHs VLCLEE4F6dQD0THTGt/M2tesLi2G0U3BuTDUw+GrNtMz8azLgkB7MYtpq8jWoCtGLPw3u8 M1fSoRYjPDq10S3Lf75e/mD5VamnceR06VmpA2L6cUogdqyQavI+zimrROBFCA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728754272; a=rsa-sha256; cv=none; b=kK2yBjOwFMUFDsQJpCVHUDwidUX4KDDQQ4/Hre6JCXwsF9ju0fny+RM3JbYCGPBi9BHMcM 8/oJBPoTwfc3wP3+BL4jwADOgbfyKCLxd62Vs8uecQXeAQi6g491rJuBnQb3yLB3s1QTb6 64C7VAs5Kjqmzg+VXJean7DKsD5295YOChXLZjLkYcvOWruKuZXCkM+0vpMboGsLoVblBW tqcGYG+5wj78ShLTmAs/PHwWVmHn1vDWPP/l6jsFeNb1vmulv1VjTfGimp5rsJVoYp8/6N m0k/ligyr3ea6r8gp+HBNumSsfxDttS/k8/vT7jO1Jz7Xb0tVnSoxewI2j3oOg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="Om7pbE/m"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA6465C4E4 for ; Sat, 12 Oct 2024 19:31:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szfwP-0005zN-Vc; Sat, 12 Oct 2024 13:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szfwO-0005yf-3O for emacs-orgmode@gnu.org; Sat, 12 Oct 2024 13:30:08 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szfwK-0008TE-Rs for emacs-orgmode@gnu.org; Sat, 12 Oct 2024 13:30:07 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 05ACB240101 for ; Sat, 12 Oct 2024 19:29:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1728754199; bh=C2tLZYKrsiHv6OY3Q7PRG7WWAZz3723N5kGLi4QdFxA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=Om7pbE/mQw59N45dAC5yHfawUpzTHzK/Z6puUr3UVYnLa921YKEd0LGRxfWH5Vplo pUowBPA9PKteLSNdgMitKNq4jGWCqleXnFSl5fIEOGTvKh0bcXnG3JzsxLVU0ZaPnA edgiV5pT+Bx+FrIoVHWk7g9BTDIdtbFase7EBmPZYm4UZdjB7HcsNVUb7s8UwKM2FE zyRxOYEZjw/YNrTcx7u44GZsS2bHXuEXVT25Un6TGbnRZf8hFTp90+Ay+xrgxtYVVU pNxJ4f1yShnUuOBwmmErK26Wo0CoGEr+uD4DLB/hMfsUeG0rLYS4W8XRBHP9EPSkkw dhIAzJG85z+FA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XQr922cd4z6tm8; Sat, 12 Oct 2024 19:29:58 +0200 (CEST) From: Ihor Radchenko To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Cc: emacs-orgmode@gnu.org Subject: Re: Org-cite: Replace basic follow-processor with transient menu? In-Reply-To: <8734lpmkjn.fsf@gmail.com> References: <8734m28l9a.fsf@gmail.com> <874j6h3rw8.fsf@localhost> <877cbamq2q.fsf@gmail.com> <87cykvrgwr.fsf@localhost> <8734lpmkjn.fsf@gmail.com> Date: Sat, 12 Oct 2024 17:31:49 +0000 Message-ID: <87r08lqlbu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.56 X-Spam-Score: -3.56 X-Migadu-Queue-Id: DA6465C4E4 X-Migadu-Scanner: mx13.migadu.com X-TUID: GEPGnPB4xvGz Tor-bj=C3=B6rn Claesson writes: >> Is there an easier way to access transient prefix command arguments from >> suffixes? Maybe something provided by transient itself? > > Yes it was way to complicated, thanks! A better way can be found reading > transient.el and magit sources. Together with your other feedback, I now = have: > > (defcustom org-cite-basic-follow-ask nil > "Should org-cite-basic ask how to follow citations?" > :group 'org-cite > :type 'boolean) > > (transient-define-prefix org-cite-basic-follow (citation &optional prefix) > "Follow a citation reference. > > New actions can be added using transient-append-suffix.=20 > The body of such new actions should have the form: > > (lambda (citation prefix) (interactive (oref (transient-prefix-object) sc= ope)) ...)" > [["Open" > ("b" "bibliography entry" org-cite-basic-follow.open-bibliography)] > ["Copy" > ("d" "DOI" org-cite-basic-follow.copy-doi)] > ["Browse" > ("u" "url" org-cite-basic-follow.browse-url)]] > (interactive) > (if (or org-cite-basic-follow-ask prefix) > (transient-setup 'org-cite-basic-follow nil nil :scope (list citati= on prefix)) > (org-cite-basic-goto citation prefix))) Thanks! This looks much more clean. Even better would be having a defcustom that defines the transient layout. The idea is to avoid hard-coding [["Open" ... ] ["Copy" ...] ...] and instead make it defcustom. > (transient-define-suffix org-cite-basic-follow.open-bibliography (citatio= n prefix) > "Find bibliography entry for citation" > (interactive (oref (transient-prefix-object) scope)) > (org-cite-basic-goto citation prefix)) >=20=20=20 > ... (oref (transient-prefix-object) scope) is equivalent to (transient-scope) > And I can then for example add my own pdf-action like this: > > (transient-append-suffix 'org-cite-basic-follow "b" > '("p" "pdf" > (lambda (citation prefix) > (interactive (oref (transient-prefix-object) scope)) > (find-file-other-window > (concat > tbc/projektet > "Referensartiklar" > "/" > (org-element-property :key citation) > ".pdf"))))) It feels a bit too complex to demand knowledge of these transient details (how to get the arglist) from users. I am wondering if we can somehow plug the existing commands passing the arguments without any extra setup on the user side. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at