emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] ‘org-element-at-point’ warning when opening a link in agenda with a mouse [9.7.11 (9.7.11-6a5d0e @ c:/Users/User/.emacs.d/elpa/org-9.7.11/)]
@ 2024-10-07 15:10 Nikolay Kudryavtsev
  2024-10-20 11:45 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Kudryavtsev @ 2024-10-07 15:10 UTC (permalink / raw)
  To: emacs-orgmode

Hello.

Recently I reworked some of my task workflows and now I have an agenda 
view that's all web links. Opening those with mouse is pretty natural.

But every time I do, I get this warning:

Warning (org-element): ‘org-element-at-point’ cannot be used in non-Org 
buffer #<buffer *Org Agenda*> (org-agenda-mode)

I sort of understand why this warning got introduced, but I think that 
mouse clicking on links in agenda is a pretty normal usage of org, so I 
believe that this warning should be suppressed in this case.

After looking into the code, it seems like this can be done by a trivial 
or check that also checks for org-agenda-mode, but that I decided to 
leave to the maintainers, because maybe there are some things that 
escaped my understanding.

Thanks.

Emacs  : GNU Emacs 29.4 (build 1, x86_64-w64-mingw32)
  of 2024-07-06
Package: Org mode version 9.7.11 (9.7.11-6a5d0e @ 
c:/Users/User/.emacs.d/elpa/org-9.7.11/)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] ‘org-element-at-point’ warning when opening a link in agenda with a mouse [9.7.11 (9.7.11-6a5d0e @ c:/Users/User/.emacs.d/elpa/org-9.7.11/)]
  2024-10-07 15:10 [BUG] ‘org-element-at-point’ warning when opening a link in agenda with a mouse [9.7.11 (9.7.11-6a5d0e @ c:/Users/User/.emacs.d/elpa/org-9.7.11/)] Nikolay Kudryavtsev
@ 2024-10-20 11:45 ` Ihor Radchenko
  2024-10-20 17:34   ` Nikolay Kudryavtsev
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2024-10-20 11:45 UTC (permalink / raw)
  To: Nikolay Kudryavtsev; +Cc: emacs-orgmode

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> Recently I reworked some of my task workflows and now I have an agenda 
> view that's all web links. Opening those with mouse is pretty natural.
>
> But every time I do, I get this warning:
>
> Warning (org-element): ‘org-element-at-point’ cannot be used in non-Org 
> buffer #<buffer *Org Agenda*> (org-agenda-mode)
>
> I sort of understand why this warning got introduced, but I think that 
> mouse clicking on links in agenda is a pretty normal usage of org, so I 
> believe that this warning should be suppressed in this case.

Thanks for reporting!
This is an annoying one.
The old behavior was erroneous - using `org-open-at-point' may actually
fail in some agenda buffers. For example, one can try to M-x
read-only-mode and then insert #+begin_src conf line before the link and
#+end_src after.

However, properly fixing it is not trivial - we will need some totally
new API for links outside Org mode.

For the time being, I suppressed the warning when clicking on links.
It will at least fix the regression.

Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=dfd6cc51f5

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] ‘org-element-at-point’ warning when opening a link in agenda with a mouse [9.7.11 (9.7.11-6a5d0e @ c:/Users/User/.emacs.d/elpa/org-9.7.11/)]
  2024-10-20 11:45 ` Ihor Radchenko
@ 2024-10-20 17:34   ` Nikolay Kudryavtsev
  0 siblings, 0 replies; 3+ messages in thread
From: Nikolay Kudryavtsev @ 2024-10-20 17:34 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Cool! Thanks!



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-20 17:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 15:10 [BUG] ‘org-element-at-point’ warning when opening a link in agenda with a mouse [9.7.11 (9.7.11-6a5d0e @ c:/Users/User/.emacs.d/elpa/org-9.7.11/)] Nikolay Kudryavtsev
2024-10-20 11:45 ` Ihor Radchenko
2024-10-20 17:34   ` Nikolay Kudryavtsev

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).