From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH 0/2] Teach org-version to include git version information Date: Wed, 19 Aug 2009 08:08:40 -0400 Message-ID: <87prasypiv.fsf@gollum.intra.norang.ca> References: <1250616163-11733-1-git-send-email-bernt@norang.ca> <668A7B70-E1E0-485E-9537-64C5A039DEF4@gmail.com> <87bpmdaqff.fsf@gollum.intra.norang.ca> <4D2E35AC-DBAB-499C-946A-2BB86D6C2AA3@gmail.com> <87tz04yrk0.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdjyB-00060V-Ks for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:08:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mdjy8-00060J-1L for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:08:47 -0400 Received: from [199.232.76.173] (port=54425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mdjy7-00060G-TI for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:08:43 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:51048) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mdjy7-0006JH-IS for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:08:43 -0400 In-Reply-To: (Manish's message of "Wed\, 19 Aug 2009 17\:31\:10 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Manish Cc: emacs-orgmode@gnu.org, Carsten Dominik Manish writes: > On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote: >> Does it crash and cause an error or report the old org version as before? > > It just reports the version as before; no crashing or error of any sort. Okay that's good. I don't have Emacs on windows here. If you have time to step through the org-version function in debug and figure out where it fails we might be able to get it working on windows too. My guess is that determining the location of the .git directory fails so it acts just like it's not running from a git repository. What do you get when evaluating the following form? (file-name-directory (locate-library "org")) I need to move up one directory from what that returns to see if the .git directory exists and I append '../' to the path to move up on *nix systems. That probably doesn't work for windows. Maybe there's a better way to strip off the last directory from the path that file-name-directory returns. -Bernt