From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: org-bbdb-anniversaries gives error 'bad sexp' Date: Mon, 16 May 2011 10:03:46 -0400 Message-ID: <87pqnivj25.fsf@fastmail.fm> References: <87wrht82iw.fsf@gmx.co.uk> <19919.63774.257976.613699@gargle.gargle.HOWL> <87k4drew8z.fsf@fastmail.fm> <19920.3805.453866.486816@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:44541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLyOl-0005qm-6R for emacs-orgmode@gnu.org; Mon, 16 May 2011 10:03:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QLyOj-0002Aw-O7 for emacs-orgmode@gnu.org; Mon, 16 May 2011 10:03:51 -0400 In-Reply-To: <19920.3805.453866.486816@gargle.gargle.HOWL> (Roland Winkler's message of "Sun, 15 May 2011 12:35:25 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Roland Winkler Cc: emacs-orgmode@gnu.org, bbdb-info@lists.sourceforge.net "Roland Winkler" writes: > On Sun May 15 2011 Matt Lundin wrote: >> I'd be happy to take this on. AFAICT, there are three functions in >> org-bbdb that no longer exist in bbdb v3. >> >> bbdb-name >> bbdb-company >> bbdb-record-getprop >> >> The first two can easily be defaliased to bbdb-search-organization and >> bbdb-search-name. (For a while, we should probably support bbdb v2 and >> v3 simultaneously.) > > Things might be a bit more subtle. The new organization field is > a list, not a single string. Thanks. That's good to know. AFAICT, bbdb-search-organization already accommodates for this fact. That is, if you give it a regexp, it will return all records matching the regexp in the organization field. Since org-bbdb calls bbdb-company with a string as an argument, wouldn't a defalias be sufficient for the time being? >> The other major change that breaks compatibility is the order of the >> parameters in bbdb-split. It has been reversed in the new bbdb: i.e., >> one used to call (bbdb-split string separator), whereas now one must >> call (bbdb-split separator string). Is there a compelling reason to >> change this order in the new bbdb? > > The change is not only with respect to the order of arguments that > could be reverted in BBDB v3. More importantly, I tried to get rid > of hard-coded separators. Most often the separator arg is now the > name of the field that is split. Then the actual separator is looked > up in bbdb-separator-alist. While I do not know yet a good strategy > for the upgrade of org-mode's BBDB interface, I'd find it > unfortunate if such a feature was lost in org-mode to preserve > backward compatibility. Thanks for the explanation. For the time being, I'll add a workaround to accommodate both versions. Best, Matt