From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tassilo Horn Subject: Re: [PATCH] Fix renumbering for footnotes at BOL. Date: Thu, 29 Sep 2011 15:46:17 +0200 Message-ID: <87pqij797a.fsf@thinkpad.tsdh.de> References: <87ehyzk8n5.fsf@thinkpad.tsdh.de> <877h4rh8z2.fsf@gmail.com> <87aa9nk1n9.fsf@thinkpad.tsdh.de> <87zkhnfqlz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:58423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9Gwc-0002Ye-0K for emacs-orgmode@gnu.org; Thu, 29 Sep 2011 09:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9GwU-00041A-6f for emacs-orgmode@gnu.org; Thu, 29 Sep 2011 09:46:33 -0400 Received: from deliver.uni-koblenz.de ([141.26.64.15]:42015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9GwU-00040y-0K for emacs-orgmode@gnu.org; Thu, 29 Sep 2011 09:46:26 -0400 In-Reply-To: <87zkhnfqlz.fsf@gmail.com> (Nicolas Goaziou's message of "Thu, 29 Sep 2011 15:03:04 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Nicolas Goaziou writes: Hi! >> I don't either, and that's a good thing. I added that just as some >> extra paranoia so that you get an error if a footnote gets broken. > > Well, provided the first part of the function doesn't modify the > buffer, I still don't see how the assert could fail, even with a > broken footnote. Now, I may also be less paranoid than you are in > that case. You are right. And the regex doesn't even match broken footnotes, that is, footnotes with missing numbers. > Do you still think that assert should be a stayer? Nope, feel free to remove that line. Bye, Tassilo