From: Rasmus <rasmus@gmx.us>
To: bzg@altern.org
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] replace function name in org-bbdb
Date: Wed, 03 Apr 2013 16:38:19 +0200 [thread overview]
Message-ID: <87ppybof1g.fsf@pank.eu> (raw)
In-Reply-To: <87txnnhlq0.fsf@bzg.ath.cx> (Bastien's message of "Wed, 03 Apr 2013 13:55:51 +0200")
Bastien <bzg@altern.org> writes:
> Hi Rasmus,
>
> Rasmus <rasmus@gmx.us> writes:
>
>>>> org-bbdb-anniversary was not working on my system before using bbdb3
>>>> from package.el (probably from MELPA...). This fixes this by renaming
>>>> a function which has been changed upstream.
>>>
>>> Looks good. Is there any versioning we can check in order to know
>>> what function's name will the users use?
>>
>> bbdb3 hasn't been released yet. It's a moving target and I would
>> assume that people who use it are on the edge of the development. . .
>> The function(s) in question were renamed four months ago.
>
> I fixed this slightly differently:
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=04b13a
>
> Thanks for spotting this and providing the patch!
Thanks! I'm extremely proud to have provided a TINYCHANGE to Org :)
Maybe it will lead the way to a real patch one day?
In any case it should probably be
-;; `bbdb-record-xfield' was part of BBDB v3.x
+;; `bbdb-record-note' was part of BBDB v3.x
–Rasmus
--
If you can mix business and politics wonderful things can happen!
next prev parent reply other threads:[~2013-04-03 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 13:17 [PATCH] replace function name in org-bbdb Rasmus
2013-03-30 14:45 ` Bastien
2013-03-30 15:51 ` Rasmus
2013-04-03 11:55 ` Bastien
2013-04-03 14:38 ` Rasmus [this message]
2013-04-03 14:46 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppybof1g.fsf@pank.eu \
--to=rasmus@gmx.us \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).