From mboxrd@z Thu Jan  1 00:00:00 1970
From: Feng Shu <tumashu@gmail.com>
Subject: Re: [PATCH] org-contacts.el: add expire feature
Date: Fri, 31 May 2013 06:56:31 +0800
Message-ID: <87ppw8krfk.fsf@news.tumashu-localhost.org>
References: <87li6yx8u9.fsf@news.tumashu-localhost.org>
	<87wqqhlchq.fsf@tanger.home>
	<2013-05-30T19-33-07@devnull.Karl-Voit.at>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33933)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tumashu@gmail.com>) id 1UiBmy-0005qe-Qp
	for emacs-orgmode@gnu.org; Thu, 30 May 2013 18:57:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tumashu@gmail.com>) id 1UiBmx-0006A0-Q3
	for emacs-orgmode@gnu.org; Thu, 30 May 2013 18:57:44 -0400
Received: from mail-pb0-x22e.google.com ([2607:f8b0:400e:c01::22e]:46409)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tumashu@gmail.com>) id 1UiBmx-00069a-JB
	for emacs-orgmode@gnu.org; Thu, 30 May 2013 18:57:43 -0400
Received: by mail-pb0-f46.google.com with SMTP id rq2so1173151pbb.19
	for <emacs-orgmode@gnu.org>; Thu, 30 May 2013 15:57:42 -0700 (PDT)
Received: from tumashu ([110.97.83.115]) by mx.google.com with ESMTPSA id
	ih1sm43691049pbb.44.2013.05.30.15.57.39 for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Thu, 30 May 2013 15:57:41 -0700 (PDT)
Received: from feng by news.tumashu-localhost.org with local (Exim 4.80)
	(envelope-from <tumashu@gmail.com>) id 1UiBlo-0002re-43
	for emacs-orgmode@gnu.org; Fri, 31 May 2013 06:56:32 +0800
In-Reply-To: <2013-05-30T19-33-07@devnull.Karl-Voit.at> (Karl Voit's message
	of "Thu, 30 May 2013 19:37:43 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Karl Voit <devnull@Karl-Voit.at> writes:

> * Daimrod <daimrod@gmail.com> wrote:
>>
>> Feng Shu <tumashu@gmail.com> writes:
>>
>>> * test
>>>   :PROPERTIES:
>>>   :EMAIL: test1@gmail.com  test2@gmail.com  test3@gmail.com
>>>   :PHONE:  123456  123457 123458
>>>   :EXPIRE:  test2@gmail.com 123457
>>>   :END:
>>>
>>> when completing or exporting to vcard,  the emails and  phones in the
>>> expire property (test2@gmail.com and 123457) will be ignore
>
> This is a very good patch, fixing an issue I also do have currently.
>
>> Since the purpose of this property is to ignore some values when
>> exporting to vcard, don't you think it would be better to name it IGNORE
>> or VCARD_IGNORE? (and of course to rename all functions accordingly)
>
> I totally agree.
>

I have changed it to "IGNORE"
> At first, I could not follow Feng Shu's explanation because I
> thought that some (meta-) data gets expired after a certain period
> of time. But then I realized that he meant that these things expired
> in the past.
>
> From the user point of view, I also do think that renaming the
> property from :EXPIRE: to :IGNORE: would be better in terms of
> understanding its purpose and how it works.
>
> (If you do tend to keep the wording, I would at least rename it to
> :EXPIRED: which emphasizes the fact that these things expired in the
> past.)

--